Feature/acastill lightpropagation update - #946
Conversation
tjones79
left a comment
There was a problem hiding this comment.
This looks great thanks @asanchezcastillo
Few minor changes before approval :)
|
Hi @tjones79 ! Thanks for the thorough review. I have implemented the requested changes and the PR should be good to go! |
|
Hi @JosiePaton , this PR requires your review since it affects the CAF data format. Just checking if you're available to review this PR soon or if we should reach out to a different CAF expert? thanks |
Hi! @tjones79 is now handling CAF changes for SBND as far as I'm aware, so the comments above should do it! |
|
Sorry @JosiePaton and thanks @tjones79 for the review! I will try to get the checklist changed to have @tjones79 under CAF reviewers for the future. |
Description
This PR does:
Checklist
Reviewers,AssigneesDevelopementRelevant PR links (optional)
Does this PR require merging another PR in a different repository (such as sbnanobj/sbnobj etc.)?
This PRs should be merged with
SBNSoftware/sbnobj#175
SBNSoftware/sbncode#666
SBNSoftware/sbnanaobj#195
Link(s) to docdb describing changes (optional)
Is there a docdb describing the issue this solves or the feature added?