Repository navigation
[Fix] 로그아웃, 세션 무효화 시 FCM 토큰 정리 - #424
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 27 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
📊 테스트 커버리지 리포트
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧾 요약
🔗 이슈
✨ 변경 내용
AuthService.login,OAuthLoginProcessor.login에서 토큰 발급 후 해당 유저의 FCM 토큰 정리AuthService.logout에서도 동일 처리 — 기존에는 블랙리스트 등록과 refresh 삭제만 했다TokenRedisService에 단일 세션이 의도임을 명시하고, 기기별 세션으로 바꿀 때 함께 손봐야 할 지점을 남김AuthService.reissue도issueTokens를 호출하지만 여기서는 정리하지 않는다. 재발급은 같은 세션의 연장이라 지우면 푸시가 영구히 끊긴다.reissueDoesNotClearFcmTokens로 고정해 뒀다💬 참고
탈퇴는 이미
UserWithdrawCleanupDispatcher에서 정리하고 있어 변경이 없습니다DELETE /api/fcm/tokens요청 본문은{ "token": "기기 FCM 토큰" }하나입니다 (deviceType 아님). 서버가 정리하므로 클라에서 반드시 호출할 필요는 없습니다✅ 확인
logout의 정리 호출을 제거하면logoutClearsFcmTokens가 실패하는 것 확인