Repository navigation
fix: 인증 사진 실패 시 실제 에러를 Sentry에 올림 - #227
Merged
Merged
Conversation
고정 문자열 new Error("TrackingPhotoUploadFailed")만 보내 실제 err를
버리고 있었다. 그래서 Sentry에 모든 실패가 한 덩어리로 묶이고, 업로드
실패인지 presigned 서명 불일치인지 savePhoto 검증 오류인지 구분할 수
없었다.
err를 그대로 captureException에 넘기고, statusCode를 태그로,
세션·마일스톤·촬영 수를 extra로 붙인다. 콘솔 로그에도 마일스톤과
상태 코드를 남겨 dev 빌드에서 바로 확인할 수 있게 한다.
409(마일스톤 중복)는 위에서 이미 따로 처리하고 return하므로 그대로 둔다.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 4 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
문제
인증 사진 실패 시 고정 문자열만 Sentry에 보내 실제 에러를 버리고 있었습니다.