Repository navigation
Preserve SQL NULL in implicit text conversions - #612
Merged
Merged
Conversation
Return nullptr for implicit text-pointer conversions, including getColumns() mappings, while retaining getText()'s safe empty-string default. Test NULL, empty, and nonempty text values.
SRombauts
added a commit
that referenced
this pull request
Oct 24, 2026
Document the intentional 4.0 behavior change in PR #612.
|
coverage: 99.735%. remained the same — 521-fix-null-text-conversion into master |
SRombauts
force-pushed
the
521-fix-null-text-conversion
branch
from
October 24, 2026 14:17
99b1b56 to
3135369
Compare
Cover string and string-view conversions alongside nullable text pointers. Clarify invalidation and allocation-failure behavior.
Point users relying on the old implicit empty-string fallback to getText(), which retains that behavior.
SRombauts
force-pushed
the
521-fix-null-text-conversion
branch
from
October 24, 2026 14:32
3135369 to
be385a0
Compare
SRombauts
added a commit
that referenced
this pull request
Oct 24, 2026
Follow up on #612: guard nullable `const char*` values in README output, correct the example's `getText(nullptr)` equivalence, and document borrowed pointer/view lifetimes in `getColumns()`. Documentation and examples only; no library behavior changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return
nullptrwhen converting a SQL NULLColumnimplicitly toconst char*, fixing nullable pointer fields populated bygetColumns(). KeepgetText()'s empty-string default and cover NULL, empty, and nonempty text. This intentional 4.0 behavior change fixes #521.