Repository navigation
chore: bump mlx-swift-lm to 6490e3f (upstream ecd8e88 sync) - #214
Merged
Merged
Conversation
Points the mlx-swift-lm submodule at SharpAI/mlx-swift-lm main after SharpAI/mlx-swift-lm#76 (real merge of ml-explore/mlx-swift-lm ecd8e88) and #75 (upstream-sync bot). mlx-swift stays at 34bc52f. No SwiftLM source change is needed. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump the
mlx-swift-lmsubmodule from4e6e521to6490e3f(SharpAI/mlx-swift-lm#76, plus #75).mlx-swiftstays at34bc52f. No SwiftLM source change is needed.Pulled in by this bump (lm-side, see the lm PR description for details):
ml-explore/mlx-swift-lmecd8e88(5 commits): generation observability (#640, token-loop handlers move into a publicTokenLoopHandler.swift), Gemma tool calls keep nested object/array arguments (#626), KV cache memory inKVCacheStatus(#639), component-aware checkpoint loading (#679:ModelCheckpoint,Qwen35CheckpointPolicy,loadModelCheckpoint(urls:)), deterministic reranker cancellation test (#669).MTPConfig.retainMTPWeights(SwiftLM--mtp) now flows through upstream's checkpoint policy as aretainMTPparameter, plus FP8 block-wise dequant, expert-streaming lazy loading, the MTP add-on file and per-layer quantization path normalization inLoad.swift.ToolCallFormat.gemma4now uses upstream'sGemmaFunctionParser(the fork's ownGemma4FunctionParsertruncated nested objects and is removed). SwiftLM does not reference it.SwiftLM change: none.
Sources/,Tests/andPackage.swiftbuild unchanged against the new lm.Test plan
Local (M5), against lm
6490e3f+ mlx-swift34bc52f:swift build -c release: OK (189 s)swift build --build-tests: OKSwiftLMTests: 276 tests, 0 failuresSwiftBuddyTests: 127 tests, 9 skipped (environment-gated). The first run had 1 failure,VLMTests.testVLM_AutoDetectsLFM25WithoutVisionFlag: the test launches the debugSwiftLMbinary, and in my fresh worktree there was nomlx.metallibnext to it (Failed to load the default metallib). After copying the metallib there,VLMTestspasses 2/2. I did not re-run the wholeSwiftBuddyTeststarget after that; the other 125 tests passed in the first run.--mtpwith a real model, the model-download integration tests,tests/test-*.sh,xcodebuild -scheme SwiftBuddyCI:
build_and_unit_testspeculative-decoding,dflash-speculative-decoding,speculative-decoding-evalintegration_matrixjobs (these exercise the hybrid prompt-cache and Qwen3.5 paths that the lm checkpoint-loading change touches)AI disclosure
This PR was prepared with AI assistance (Claude Code: build/test runs and this description). It still needs human review before merging.
🤖 Generated with Claude Code