Repository navigation
fix(sitecore-jss-vue): preserve query string in RichText internal links (#2191) - #2221
Open
Ravi-Rabadiya-fullstack wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2191
The
RichTextcomponent'srouteHandlermethod in@sitecore-jss/sitecore-jss-vuepreviously constructed the navigation destination using onlytarget.pathnameandtarget.hash, omittingtarget.search. Consequently, internal links with query parameters (e.g.,/my-page?type=foo§ion=bar) lost their query string during client-side SPA routing.This PR updates
routeHandlerto includetarget.searchalongsidetarget.pathnameandtarget.hash.Changes
packages/sitecore-jss-vue/src/components/RichText.tsto includetarget.searchwhen building the destination URL.packages/sitecore-jss-vue/src/components/RichText.test.tsto test links with query strings (both with and without hash fragments).Verification
yarn testin@sitecore-jss/sitecore-jss-vuepasses (10/10 suites, 97/97 tests).yarn lintpasses.yarn buildcompiles CJS and ESM distributions cleanly.yarn lint-packagespasses across all monorepo packages.