Repository navigation
fix(linux): make the Confirm Before Deleting Rows switch take effect - #3448
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Preferences showed a Confirm Before Deleting Rows switch that nothing read. Its description promised confirmations for dropping tables and discarding edits that never existed. Separately, a save landing after the user closed the Edit Connection dialog closed it again, and libadwaita logged a critical.
Change
confirm-bulk-delete, read at each delete, so a change reaches open tabs. The row's subtitle states the threshold.Verified
The two browse tab tests and the late-save test fail before the fix and pass after. The full gtk suite and the storage tests pass, and fmt and both clippy runs are clean.