Repository navigation
build(linux): extract path-qualified gettext calls with gettext 1.0 - #3450
Merged
Merged
Conversation
This was referenced Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Most user-facing strings were missing from
po/tablepro.pot, so no translation could cover them. The app calls the i18n wrappers through a path,crate::i18n::gettext(...), in 824 of about 980 places. gettext 0.24 to 0.26 read Rust but skip a path-qualified call, and the Translations job ran gettext 0.26 from fedora:44. The committed template has 426 strings.Change
ubuntu:26.10, whose gettext 1.0 reads those calls. The same Meson target and keywords apply.po/meson.buildwarns below 1.0 instead of 0.24.po/README.md,docs/testing.mdand the verification reference say 1.0.po/tablepro.potregenerated by that job.Verified
xgettext 1.0 extracts the path-qualified calls in
connection_list_banner.rsanddelete_connection_dialog.rs, plural included, which the committed template lacks. The Translations job passes with the regenerated template.Not in this PR
main's copy ofbuild-linux.ymlneeds the same change so the two stay identical (ci(linux): add the Linux workflow and weekly dispatcher to main #3441).