Repository navigation
chore(plugins): fix notes left stale by the plugin manager cleanup - #3491
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#3482 left two comments describing code it deleted, and shipped a visible change without a CHANGELOG line.
Change
ColumnDefaultVocabularyno longer points at the deletedPluginMetadataRegistry.fallbackCategory.Content-Lengthreports only the final 1.Verified
Comments and CHANGELOG only.
ColumnDefaultVocabularyTestsand the app build pass.Not in this PR
isCompatibleKithelper.validateBundleVersionsis the one gate beforeatomicReplaceand needs the direction for its two errors;rejectedActionandresolvedBinarytake the bounds as parameters for their tests.