Repository navigation
fix(datagrid): show Table Info once a table tab's rows arrive - #3595
Merged
Merged
Conversation
The inspector's Table Info load ran as a table tab opened, returned because the rows had not arrived, and nothing ran it again when they did, so the panel showed "No Row Selected" until the pane was switched away and back. The load now runs from one task keyed on the tab, the table's identity, whether its rows have arrived and whether the inspector is on screen. The cache is the published source the inspector snapshot follows, matched on the whole table identity. A late read is dropped only when its tab moved to another table, never replaces a newer read, and a read across a comment edit cannot mark the cache current. A comment edit keeps the old numbers until the new ones land, a rename keeps them, query tabs show none, and the filter bar's suggestions follow the tab's scope.
datlechin
added
the
backport release/0.82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
With the inspector open, clicking a table showed "No Row Selected" instead of its Table Info, until the pane was switched to the assistant and back. The load ran as the tab opened, returned because the rows had not arrived, and never ran again.
Change
Verified
TrailingPaneRevealTests"Table Info shows once a table tab's rows arrive" fails on main and passes here.MainContentCoordinatorTableMetadataTestschanged: it read the removedtableMetadataslot.Screenshots
Not in this PR
features/json-viewer.mdxdescribes.