Skip to content

posix drivers, mock drivers and struct Driver changes - #687

Merged
KenVanHoeylandt merged 3 commits into
mainfrom
develop
Oct 11, 2026
Merged

KenVanHoeylandt merged 3 commits into
mainfrom
develop

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor
  • Implement UART and I2C drives for posix
  • Add posix scanning service to discover devices (path-based scanning)
  • Move mock wifi driver to separate driver project, in Drives/
  • struct Driver doesn't contain owner module anymore. Moved to internal data.
  • Improved UX of apps: SelectionDialog, GpsSettings, AddGps
  • Fix bugs in gps-module
  • Fix for symbol issue in TactilitySDK

@coderabbitai

coderabbitai Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Too many files!

This PR contains 180 files, which is 30 over the limit of 150.

To get a review, reduce the PR to 150 files or fewer by splitting it into smaller PRs or changing its base branch.

Upgrade to a paid plan to raise the limit.

This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 13b7bc33-4640-4012-ab7a-c19828beb13b

📥 Commits

Reviewing files that changed from the base of the PR and between b9a96ca and 99d5707.


📒 Files selected for processing (180)
  • Buildscripts/TactilitySDK/TactilitySDK.esp32.cmake
  • CMakeLists.txt
  • Devices/cl32-v04/source/cl32_v4_keyboard.cpp
  • Devices/cl32-v04/source/cl32_v4_light.cpp
  • Devices/cl32-v04/source/cl32_v4_power.cpp
  • Devices/m5stack-papers3/source/drivers/papers3_display.cpp
  • Devices/m5stack-papers3/source/drivers/papers3_power.cpp
  • Devices/m5stack-tab5/Source/devices/tab5_keyboard.cpp
  • Devices/m5stack-tab5/Source/devices/tab5_power_control.cpp
  • Devices/simulator/Source/drivers/sdl_display.cpp
  • Devices/simulator/Source/drivers/sdl_keyboard.cpp
  • Devices/simulator/Source/drivers/sdl_pointer.cpp
  • Devices/simulator/module.yaml
  • Devices/simulator/simulator.dts
  • Devices/unphone/source/drivers/unphone_nav_buttons.cpp
  • Devices/unphone/source/drivers/unphone_power_switch.cpp
  • Documentation/ideas.md
  • Drivers/ads1115-module/source/ads1115.cpp
  • Drivers/audio-stream-module/source/audio_stream.cpp
  • Drivers/audio-stream-module/tests/source/audio_stream_open_race_test.cpp
  • Drivers/aw88298-module/source/aw88298.cpp
  • Drivers/aw9523b-module/source/aw9523b.cpp
  • Drivers/axp192-module/source/axp192.cpp
  • Drivers/axp192-module/source/axp192_backlight.cpp
  • Drivers/axp2101-module/source/axp2101.cpp
  • Drivers/axp2101-module/source/axp2101_backlight.cpp
  • Drivers/axs5106-module/source/axs5106.cpp
  • Drivers/bm8563-module/source/bm8563.cpp
  • Drivers/bmi270-module/source/bmi270.cpp
  • Drivers/bq24295-module/source/bq24295.cpp
  • Drivers/bq25896-module/source/bq25896.cpp
  • Drivers/bq27220-module/source/bq27220.cpp
  • Drivers/button-control-module/source/button_control.cpp
  • Drivers/ch422g-module/source/ch422g.cpp
  • Drivers/cst328-module/source/cst328.cpp
  • Drivers/cst66xx-module/source/cst66xx.cpp
  • Drivers/cst816s-module/source/cst816s.cpp
  • Drivers/cst816t-module/source/cst816t.cpp
  • Drivers/drv2605-module/source/drv2605.cpp
  • Drivers/dummy-i2s-amp-module/source/dummy_i2s_amp.cpp
  • Drivers/es7210-module/source/es7210.cpp
  • Drivers/es7243e-module/source/es7243e.cpp
  • Drivers/es8311-module/source/es8311.cpp
  • Drivers/es8388-module/source/es8388.cpp
  • Drivers/esp-epaper-module/source/esp_epaper.cpp
  • Drivers/esp32-dac-speaker-module/source/esp32_dac_speaker.cpp
  • Drivers/esp32-led-strip-module/source/esp32_led_strip.cpp
  • Drivers/ft5x06-module/source/ft5x06.cpp
  • Drivers/ft6x36-module/source/ft6x36.cpp
  • Drivers/gc0308-module/source/gc0308.cpp
  • Drivers/gc9a01-module/source/gc9a01.cpp
  • Drivers/gdeq031t10-module/source/gdeq031t10.cpp
  • Drivers/gpio-encoder-module/source/gpio_encoder.cpp
  • Drivers/gpio-trackball-module/source/gpio_trackball.cpp
  • Drivers/gps-meshtastic-module/source/gps_meshtastic.cpp
  • Drivers/gt911-module/source/gt911.cpp
  • Drivers/hx8357-module/source/hx8357.cpp
  • Drivers/ili9341-module/source/ili9341.cpp
  • Drivers/ili9488-module/source/ili9488.cpp
  • Drivers/ili9881c-module/source/ili9881c.cpp
  • Drivers/ina226-module/source/ina226.cpp
  • Drivers/jd9165-module/source/jd9165.cpp
  • Drivers/jd9853-module/source/jd9853.cpp
  • Drivers/lilygo-module/source/tdeck_keyboard.cpp
  • Drivers/lilygo-module/source/tdeck_keyboard_backlight.cpp
  • Drivers/lilygo-t5s3-epd-module/source/t5s3_display.cpp
  • Drivers/lp5814-module/source/lp5814.cpp
  • Drivers/m5pm1-module/source/m5pm1.cpp
  • Drivers/m5stack-module/source/cardputer_adv_keyboard.cpp
  • Drivers/m5stack-module/source/cardputer_keyboard.cpp
  • Drivers/mock-drivers-module/CMakeLists.txt
  • Drivers/mock-drivers-module/LICENSE-Apache-2.0.md
  • Drivers/mock-drivers-module/bindings/mock,wifi.yaml
  • Drivers/mock-drivers-module/include/bindings/mock_wifi.h
  • Drivers/mock-drivers-module/include/mock/mock_wifi.h
  • Drivers/mock-drivers-module/include/mock_drivers_module.h
  • Drivers/mock-drivers-module/module.yaml
  • Drivers/mock-drivers-module/source/mock_wifi.cpp
  • Drivers/mock-drivers-module/source/module.cpp
  • Drivers/mpu6886-module/source/mpu6886.cpp
  • Drivers/nv3031b-module/source/nv3031b.cpp
  • Drivers/pdm-mic-module/source/pdm_mic.cpp
  • Drivers/pi4ioe5v6408-module/source/pi4ioe5v6408.cpp
  • Drivers/py32ioexpander-module/source/py32ioexpander.cpp
  • Drivers/qmi8658-module/source/qmi8658.cpp
  • Drivers/rgb-display-module/source/rgb_display.cpp
  • Drivers/rx8130ce-module/source/rx8130ce.cpp
  • Drivers/sc2356-module/source/sc2356.cpp
  • Drivers/ssd1306-module/source/ssd1306.cpp
  • Drivers/st7121-module/source/st7121.cpp
  • Drivers/st7123-module/source/st7123.cpp
  • Drivers/st7123-module/source/st7123_touch.cpp
  • Drivers/st7305-module/source/st7305.cpp
  • Drivers/st7701-module/source/st7701.cpp
  • Drivers/st7735-module/source/st7735.cpp
  • Drivers/st7789-i8080-module/source/st7789_i8080.cpp
  • Drivers/st7789-module/source/st7789.cpp
  • Drivers/st7789-soft-i8080-module/source/st7789_soft_i8080.cpp
  • Drivers/st7796-i8080-module/source/st7796_i8080.cpp
  • Drivers/st7796-module/source/st7796.cpp
  • Drivers/sx126x-module/source/sx1262.cpp
  • Drivers/sy6970-module/source/sy6970.cpp
  • Drivers/tca8418-module/source/tca8418.cpp
  • Drivers/tca9534-module/source/tca9534.cpp
  • Drivers/tca95xx-16bit-module/source/tca95xx.cpp
  • Drivers/xl9555-module/source/xl9555.cpp
  • Drivers/xpt2046-module/source/xpt2046.cpp
  • Drivers/xpt2046-softspi-module/source/xpt2046_softspi.cpp
  • Modules/gps-module/include/gps/gps_settings.h
  • Modules/gps-module/private/gps/private/gps_ledger.h
  • Modules/gps-module/source/gps_ledger.cpp
  • Modules/gps-module/source/gps_settings.cpp
  • Modules/gps-module/source/module.cpp
  • Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble.cpp
  • Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble_hid.cpp
  • Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble_midi.cpp
  • Platforms/platform-esp32/source/drivers/bluetooth/esp32_ble_spp.cpp
  • Platforms/platform-esp32/source/drivers/esp32_adc_oneshot.cpp
  • Platforms/platform-esp32/source/drivers/esp32_gpio.cpp
  • Platforms/platform-esp32/source/drivers/esp32_grove.cpp
  • Platforms/platform-esp32/source/drivers/esp32_i2c_master.cpp
  • Platforms/platform-esp32/source/drivers/esp32_i2s.cpp
  • Platforms/platform-esp32/source/drivers/esp32_i8080.cpp
  • Platforms/platform-esp32/source/drivers/esp32_pwm_ledc.cpp
  • Platforms/platform-esp32/source/drivers/esp32_sdmmc.cpp
  • Platforms/platform-esp32/source/drivers/esp32_sdspi.cpp
  • Platforms/platform-esp32/source/drivers/esp32_spi.cpp
  • Platforms/platform-esp32/source/drivers/esp32_uart.cpp
  • Platforms/platform-esp32/source/drivers/esp32_wifi.cpp
  • Platforms/platform-esp32/source/drivers/esp32_wifi_pinned.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usb_cdc_device.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usb_device_controller.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usb_device_msc.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usb_hid_device.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usb_midi_device.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usbhost.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usbhost_hid.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usbhost_midi.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usbhost_msc.cpp
  • Platforms/platform-esp32/source/drivers/usb/esp32_usbhost_uac.cpp
  • Platforms/platform-posix/CMakeLists.txt
  • Platforms/platform-posix/bindings/posix,i2c.yaml
  • Platforms/platform-posix/bindings/posix,uart.yaml
  • Platforms/platform-posix/include/tactility/bindings/posix_i2c.h
  • Platforms/platform-posix/include/tactility/bindings/posix_uart.h
  • Platforms/platform-posix/include/tactility/drivers/posix_i2c.h
  • Platforms/platform-posix/include/tactility/drivers/posix_uart.h
  • Platforms/platform-posix/include/tactility/posix_services.h
  • Platforms/platform-posix/module.yaml
  • Platforms/platform-posix/source/drivers/posix_i2c.cpp
  • Platforms/platform-posix/source/drivers/posix_uart.cpp
  • Platforms/platform-posix/source/module.cpp
  • Platforms/platform-posix/source/posix_device_scanner.cpp
  • Platforms/platform-posix/source/posix_services.cpp
  • Tactility/Source/Init.cpp
  • Tactility/Source/InitApps.cpp
  • Tactility/Source/InitServices.cpp
  • Tactility/Source/app/addgps/AddGps.cpp
  • Tactility/Source/app/gpssettings/GpsSettings.cpp
  • Tactility/Source/app/selectiondialog/SelectionDialog.cpp
  • Tactility/Source/bluetooth/BluetoothHidHost.cpp
  • TactilityKernel/include/tactility/driver.h
  • TactilityKernel/private/tactility/driver_internal.h
  • TactilityKernel/source/driver.cpp
  • TactilityKernel/source/drivers/battery_sense.cpp
  • TactilityKernel/source/drivers/gpio_backlight.cpp
  • TactilityKernel/source/drivers/gpio_hog.cpp
  • TactilityKernel/source/drivers/pwm_backlight.cpp
  • TactilityKernel/source/drivers/rgb_led_gpio.cpp
  • TactilityKernel/source/drivers/rgb_led_pwm.cpp
  • TactilityKernel/source/drivers/root.cpp
  • TactilityKernel/source/module.cpp
  • TactilityKernel/source/symbols.c
  • TactilityKernel/tests/source/device_get_put_test.cpp
  • TactilityKernel/tests/source/device_hotplug_test.cpp
  • TactilityKernel/tests/source/device_test.cpp
  • TactilityKernel/tests/source/driver_integration_test.cpp
  • TactilityKernel/tests/source/driver_test.cpp
  • TactilityKernel/tests/source/keyboard_test.cpp
  • TactilityKernel/tests/source/module_test.cpp

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@KenVanHoeylandt
KenVanHoeylandt merged commit f707ac8 into main Oct 11, 2026
69 checks passed
@KenVanHoeylandt
KenVanHoeylandt deleted the develop branch October 11, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant