fix(solid-query): commit the idle read of a disabled query on the server - #11349
Open
lazerg wants to merge 1 commit into
Open
fix(solid-query): commit the idle read of a disabled query on the server#11349lazerg wants to merge 1 commit into
lazerg wants to merge 1 commit into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lazerg
force-pushed
the
fix/issue-11348-disabled-query-ssr-hang
branch
from
August 31, 2026 22:59
a6da2cd to
ef0ea76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
A
useQuerywithenabled: falseand nothing cached stops an SSR render from ever finishing: no bytes are emitted at all.In
computeData, the pending-idle path for a disabled query returnsNEVER, a promise that never settles. That is the right client behavior — the reader parks in the nearest<Loading>until an enabling change, a refetch or a cache write revives it. The server has no later: the render has to finish, and nothing will enable the query or write the cache before it does.So the server now commits the idle read instead, which is the settled SSR truth for a disabled query and the same contract the meta channel already honors for one. Resolving with
undefinedwas rejected for the v5 line in #8345 because it does not match the shapequeryFnreturns, and that objection stands on the client, where suspending costs nothing and the query may still start. On the server the alternative is not suspension but a page that never responds, so the type docblock now carries the exception. The client path is untouched.The hydration fixture grows a disabled query in a boundary of its own, so the regression test covers both sides: the server emits the idle face, and the hydrating client adopts it without fetching. Without the fix the fixture's SSR entry never settles and the whole suite fails.
Fixes #11348
✅ Checklist
pnpm run test:pr.🚀 Release Impact