Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The oxygen collector previously collected about 9 buckets of oxygen per tick in the overworld which seems like way too much.
This PR reduces the maximum collection amount to 50 millibuckets per tick which is equivalent to 1 bucket per tick. This is the amount the oxygen collector collects in an oxygen world and in a non-oxygen world 1 millibucket of oxygen is collected per tick for each 16 leaf blocks (or equivalent) within an 11x11x11 cube centered on the oxygen collector, up to the maximum of 50mB/t.
Currently crops provide 0.75 times the amount of oxygen as each leaf block, however, since crops have to be planted on dirt, the maximum number of crops that can fit in the 11x11x11 cube is much less than the maximum number of leaf blocks. Perhaps the oxygen provided by each crop could vary based on the growth stage with a fully grown crop providing more than a leaf block.
Feedback/opinions about the right numbers to choose for a balanced experience would be greatly appreciated.
Additionally, the amount of oxygen being collected was not being displayed correctly in the oxygen collector screen.