Repository navigation
feat: 토너먼트 위시 가져오기 폴더 칩 화면 정식 경로 통합 - #783
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 26 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
ychany
force-pushed
the
feat/733-cleanup
branch
from
November 2, 2026 11:14
3b50fbf to
da080ed
Compare
ychany
force-pushed
the
feat/782-by-wish-folder-chip
branch
from
November 2, 2026 11:14
fe9d1e0 to
3e45d3c
Compare
ychany
force-pushed
the
feat/733-cleanup
branch
2 times, most recently
from
November 2, 2026 11:48
f855464 to
19474e1
Compare
- by-wish 화면에 폴더 칩 · 위시 그리드 · 위시 없음 모달 적용 - 폴더 칩 컴포넌트 · 모달 · 폴더별 위시 훅을 by-wish-v2 에서 이관 - 기존 규칙 유지 - READY 위시만 표시 · 이미 후보에 담긴 상품 제외 - 다음 버튼은 기존 후보 담기 API 와 성공 · 에러 처리 그대로 - 선택 상태에 위시 id 와 상품 id 를 함께 저장 - 원인: 칩을 오가며 고른 위시도 함께 담아야 함 - 쓰지 않게 된 WishSelectCard · WishSelectHeader · useWishSelection 삭제
- by-wish-v2 페이지 · TOURNAMENT_ADD_ITEM_BY_WISH_V2 삭제 - getRouteType 의 v2 경로와 테스트 정리
- 칩을 오가며 고른 위시를 함께 담기 - 이미 후보에 담긴 상품 제외 - 기존 담기 시나리오에 폴더 목록 목 추가
ychany
force-pushed
the
feat/782-by-wish-folder-chip
branch
from
November 2, 2026 11:52
3e45d3c to
baa0374
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 요약
by-wish-v2를 제거합니다작업 세부 내용
머지 조건
feat/733-cleanup). 폴더 칩 API 연결이 feat: 토너먼트 폴더 칩 API 연결 및 위시 목 데이터 제거 (4단계) #780 에 있음dev로 변경화면 교체
WishSelectCardWishGridN/담을 수 있는 수개 선택TournamentErrorDialog유지한 규칙
다음은 기존 후보 담기 API · 성공 이동 · 에러 처리 그대로칩 사이 선택 유지
정리
by-wish-v2페이지 ·ByWishV2ContentFolderChipFilter·NoWishDialog·useFolderWishesby-wish로 이관WishSelectCard·WishSelectHeader·useWishSelectionTOURNAMENT_ADD_ITEM_BY_WISH_V2·getRouteTypev2 경로시안과 다른 점
0/27개 선택테스트
tournamentItemAdd에 2개 추가스크린샷
연관 이슈
closes #782