Freeze: Fixed group-frozen tracks going silent when not rendered to any output device - #438
Merged
Merged
Conversation
…ck graph Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
…red to any output device TrackOutput::outputsToDevice compared the stored output (a device ID since the switch to IDs) with a device name, so a track routed to a specific output device was never included in its device's group-freeze render. Edit::updateFrozenTracks also left tracks that weren't rendered (e.g. muted) group-frozen, which removes them from the playback graph with nothing to play back. They're now unfrozen with a warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #438 +/- ##
===========================================
+ Coverage 60.64% 60.81% +0.16%
===========================================
Files 568 568
Lines 80287 80392 +105
Branches 12406 12418 +12
===========================================
+ Hits 48690 48887 +197
+ Misses 31597 31505 -92 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Group-frozen tracks could go silent with no error. Two fixes:
TrackOutput::outputsToDevicenow matches a track whose output is stored as a device ID. It resolves the ID and compares the device's name.Edit::updateFrozenTracksnow unfreezes any group-frozen track that didn't make it into a device's freeze render (e.g. it's muted, or its output device isn't available), and shows a warning, instead of leaving it frozen and silent.Root cause
WaveOutputDevice. A track is only included ifgetOutput().outputsToDevice (outputDevice->getName(), true)is true and it isn't muted.9ed2e5d5526("Refactored TrackOutput to use device IDs rather than names", 2024-08),TrackOutput::outputDeviceholds a device ID.outputsToDevicewas still comparing it with a device name, so a track routed to a specific device never matched. Only the "(default audio output)" alias path still worked.updateFrozenTracksskips the render silently. The tracks keepfrozen = true, socreateNodeForTrackdrops them from the live graph, andcreateNodeForFrozenOutputDevicehas no file to play. The result is a frozen, silent track and no error.Regression tests (
tracktion_Renderer.test.cpp, freeze block)EnginePlayerdevice, so it's deterministic without audio hardware. It checks the default alias and a specific device ID. The specific-ID case failed before the fix.The full TestRunner suite passes: 379 doctest cases and the JUCE tests.
Note
The new warning string needs a translation pass on the app side.
Fixes Tracktion/waveform_beta#1146
🤖 Generated with Claude Code