Skip to content

Port epiworld NH-close (UofUEpiBio/epiworld#370) - #232

Merged
gvegayon merged 1 commit into
v1-layersfrom
port-nh-close
Nov 10, 2026
Merged

gvegayon merged 1 commit into
v1-layersfrom
port-nh-close

Conversation

@gvegayon

Copy link
Copy Markdown
Member

Ports UofUEpiBio/epiworld#370; vendors 71124a959146eccf0fb801bcdc0866e3ed23a2e3.

  • Diagrams without transition labels. draw_natural_history() now returns one unlabeled arrow per pair of stages (or statuses) that some transition joins; kinds, values and names are no longer drawn. The test that expected the duration arrow (s1 ==>) now expects s1 --> s2 and no labels; the help page and NEWS say so.
  • Nothing else to bind: the quarantine exemption by tool name is in the measles models (measles package).

Checks: in the container, roxygenise(), R CMD INSTALL --preclean and the tinytest suite: 801 tests, 0 failures. R CMD check was not run locally; CI runs it.

🤖 Generated with Claude Code

…o/epiworld#370)

Vendors 71124a95. draw_natural_history() now draws one unlabeled arrow per
pair of stages a transition joins; the test and the help follow.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>

@gvegayon gvegayon left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review note: the epiworldRShiny-cran downstream job is failing because the CRAN epiworldRShiny examples still call now-defunct ModelSEIRCONN(). The runbook deliberately defers the Shiny port, so please either designate this as an expected/allowed v1-layers failure or record it in the PR description; otherwise this otherwise-correct port is left with unexplained red CI.

@gvegayon
gvegayon merged commit 2f1a5ac into v1-layers Nov 10, 2026
9 of 11 checks passed
@gvegayon
gvegayon deleted the port-nh-close branch November 10, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant