Repository navigation
Port epiworld NH-close (UofUEpiBio/epiworld#370) - #232
Merged
Merged
Conversation
…o/epiworld#370) Vendors 71124a95. draw_natural_history() now draws one unlabeled arrow per pair of stages a transition joins; the test and the help follow. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
gvegayon
commented
Nov 10, 2026
gvegayon
left a comment
Member
Author
There was a problem hiding this comment.
Review note: the epiworldRShiny-cran downstream job is failing because the CRAN epiworldRShiny examples still call now-defunct ModelSEIRCONN(). The runbook deliberately defers the Shiny port, so please either designate this as an expected/allowed v1-layers failure or record it in the PR description; otherwise this otherwise-correct port is left with unexplained red CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports UofUEpiBio/epiworld#370; vendors 71124a959146eccf0fb801bcdc0866e3ed23a2e3.
draw_natural_history()now returns one unlabeled arrow per pair of stages (or statuses) that some transition joins; kinds, values and names are no longer drawn. The test that expected the duration arrow (s1 ==>) now expectss1 --> s2and no labels; the help page and NEWS say so.Checks: in the container,
roxygenise(),R CMD INSTALL --precleanand the tinytest suite: 801 tests, 0 failures.R CMD checkwas not run locally; CI runs it.🤖 Generated with Claude Code