Modernize CI: ruby 3.0–4.0 matrix, pinned actions, audit/zizmor/lint, trusted publishing - #299
Merged
Conversation
… trusted publishing
- .github/dependabot.yml: add Dependabot cooldown (default-days: 7) so the zizmor dependabot-cooldown audit passes. - viewpoint.gemspec: declare ostruct and base64 as runtime dependencies. Ruby 4.0 moved ostruct from default to bundled gems, so 'require ostruct' fails under 'bundle exec' without the declaration. - .github/workflows/ci.yml: make the lint job advisory-only (continue-on-error) for this first pass; the legacy codebase has many pre-existing RuboCop offenses slated for a dedicated cleanup pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Modernizes Viewpoint's CI to the shared WinRb CI baseline:
.github/workflows/ci.yml, replacing oldruby.yml): ruby 3.0–4.0 on ubuntu-latest + windows-latest; all actions pinned by SHA (checkout v7.0.1, setup-ruby v1.321.0, zizmor v0.6.3). Drops EOL ruby 2.7 and unpinnedsetup-ruby@v1.auditjob:bundle-audit check --update+ruby-audit check(with the CVE-2026-41316 ignore for pre-4.0.3 rubies).zizmorjob: workflow security lint.lintjob:bundle exec rubocop --format githubwith a new.rubocop.yml(repo had none)..github/workflows/gem_push.yml+releaseenvironment (pcai as required reviewer), so publishing a GitHub release pushes the gem via OIDC — no API key or OTP needed.RELEASING.md,CHANGELOG.md, PR + issue templates; existing.github/dependabot.ymlverified present.rubocop,bundler-audit (~> 0.9.3),ruby_audit (~> 3.1)(ruby_audit only on RUBY_VERSION >= 3.1.0). No changes torequired_ruby_versionin the gemspec.Note: rubocop is new to this repo, so the lint job may surface many pre-existing offenses on first run — cleanup can be a follow-up.
Test plan