Dominant Color: Tidy Up and Add GD tests - #2527

Merged

westonruter merged 14 commits into

WordPress:trunkfrom

nickchomey:fix/tidy-and-gd-tests

Aug 31, 2026

Commits on Aug 28, 2026

allow falling back to original image if no subsizes available
nickchomey
committed
715f0d5
always override core image editor classes, such that same editor is used for initial image processing and dominant colours
nickchomey
committed
27f544e
remove redundant fn call
nickchomey
committed
b0768fa
abstract the get metadata functions
nickchomey
committed
49bc0fd
Remove unnecessary wp_maybe_generate_attachment_metadata calls. They never do anything in any test
nickchomey
committed
2f26844
use create rather than create_upload_object, which prevents calling dominant_color_get_dominant_color_data. So not redundant to call it afterwards
nickchomey
committed
593a8b4
require the editor classes, just in case (seems to be missing when the GD tests tun, though not for imagick)
nickchomey
committed
b6768f0
implement GD tests
nickchomey
committed
9f94ae1
return raw rgb rather than hex. This will facilitate the lqip gradient stuff coming in other PR. Also, cleaner to just convert in one place for all editors
nickchomey
committed
8d5f9de
fix linting
nickchomey
committed
a226e02

Commits on Aug 29, 2026

Address Copilot review comments on PR #2527
nickchomey
committed
cd27d47

Commits on Aug 30, 2026

revert get_dominant_color to returning hex rather than array - broke back compat and wasn't even necessary in the end
nickchomey
committed
63ae8fa

Commits on Aug 31, 2026

address review comments
nickchomey
committed
df0de11
Apply batched suggestions from code review

nickchomey
and
westonruter
authored
61e31fc