Repository navigation
docs: qualify Ghidra default return and auto storage checks - #1030
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Saved Ghidra storage checks can falsely infer AL:1 from neutral undefined's datatype length, or reject a correct automatic this by removing the auto tag from only the expected string. Document the two reproduced pitfalls and the saved-storage checks agents should use.
Linked issue
none
Evidence
Installed Ghidra 12.1.2 source and actual read-only saved-program observations establish these API details. The 0x5687F0 return remains DefaultDataType, length 1, , with no return varnodes after the checked receiver write; saved BEFORE also has . DynamicVariableStorage includes the literal auto tag, with an independent isAutoParameter flag. These observations make no native return-declaration or gameplay-parity claim.
Tests run
AI assistance
Codex wrote the documentation and checked it against installed source and saved-program observations.
Checklist
README gameplay status is unaffected.