Repository navigation
docs: qualify neutral Ghidra return width assumptions - #1033
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Neutral
undefined4can force a full EAX result when a native exit defines only AL, causing Ghidra to invent an incoming-register expression. Document the Factory AI example and the checks needed before assigning an unknown return width or inferringvoidfrom a discarded result.Validation: original active-retail instructions at
0x004C9B28,0x004C9C41,0x0055B680and0x0055B683, plus actual shared/private C reads of0x004C9B20, confirm this specific pitfall. The database correction remains held for rehearsal; this PR only updates guidance.git diff --checkpasses.