Skip to content

feat: add system advarg to playlist commands - #95

Merged
wizzomafizzo merged 1 commit into
mainfrom
feat/playlist-system
Nov 6, 2026
Merged

wizzomafizzo merged 1 commit into
mainfrom
feat/playlist-system

Conversation

@wizzomafizzo

@wizzomafizzo wizzomafizzo commented Nov 6, 2026 •

Copy link
Copy Markdown
Member

Adds a system advarg to PlaylistArgs, so a folder playlist can be limited to one system's media, the way a browse filtered by that system lists them. Mirrors the start advarg from #92.

Summary by CodeRabbit

  • New Features
    • Folder playlists can now be limited to media from a specified system. This lets you create a playlist that includes only items from that system, consistent with browsing media filtered by the same system.
    • The system setting is optional, so existing folder playlists continue to include media across systems when no system is specified.

@coderabbitai

coderabbitai Bot commented Nov 6, 2026 •

Copy link
Copy Markdown

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

PlaylistArgs now accepts an optional system argument. The field uses system validation, and a test checks that it has the expected argument tag.

Changes: Playlist system argument

Layer / File(s) Summary
Add and validate the system argument
types.go, types_advargs_test.go
PlaylistArgs adds an optional System field with system validation. Its comment describes the folder-playlist restriction. The test checks that the field uses the KeySystem argument tag.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Feature

Merge Risk: Low · up to a412c

The new system option lacks validation coverage, so regressions could go unnoticed. Merge with a test follow-up.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@codecov

codecov Bot commented Nov 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@wizzomafizzo
wizzomafizzo merged commit dd2778f into main Nov 6, 2026
11 of 12 checks passed
@wizzomafizzo
wizzomafizzo deleted the feat/playlist-system branch November 6, 2026 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant