Skip to content

chore(a2a-slimrpc): remove old collaborate API - #580

Open
Tehsmash wants to merge 9 commits into
feat/a2acli-collaboratefrom
chore/remove-slimrpc-collaborate
Open

Tehsmash wants to merge 9 commits into
feat/a2acli-collaboratefrom
chore/remove-slimrpc-collaborate

Conversation

@Tehsmash

Copy link
Copy Markdown
Collaborator

Summary

Removes the SLIMRPC-specific collaborative channel extension (separate SLIM service, raw proto Message broadcast) that predates the new relay-based collaborative task spec.

Superseded by:

  • a2a-collab crate (§5.1 stream translation + AgentCard pre-flight checks)
  • a2acli collaborate subcommand (Basic Relay §2.1)

What's removed:

  • A2A_COLLABORATIVE_CHANNEL_SERVICE and METHOD_COLLABORATE constants
  • SlimRpcTransport::new_group(), new_group_with_connection(), collaborate()
  • Server::register_collaborate() helper
  • slimrpc_collaborate_broadcasts_to_every_other_member e2e test

SLIMRPC native-mode server (using SLIM shared-responses) is deferred — see TODO(#569) in e2e.rs.

Closes #569

Part of #568

@Tehsmash
Tehsmash requested a review from a team as a code owner November 20, 2026 12:13
@Tehsmash
Tehsmash added this pull request to stack #582 November 20, 2026 12:15
@codecov

codecov Bot commented Nov 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Tehsmash
Tehsmash force-pushed the chore/remove-slimrpc-collaborate branch 3 times, most recently from 3f6c6f0 to a5b23e2 Compare November 20, 2026 13:33
@Tehsmash
Tehsmash force-pushed the chore/remove-slimrpc-collaborate branch from a5b23e2 to ae145ec Compare November 20, 2026 13:41
E-commerce scenario with three specialist agents (orders, inventory,
shipping), mirroring the Go reference at:
a2aproject/experimental-cpb-slimrpc@3a82760

Agents have hardcoded domain data (no LLM) and respond only to queries
that touch their domain via keyword matching:
- orders:    ORD-1001 status, tracking numbers
- inventory: P-500 Wireless Headphones stock levels
- shipping:  TRK-9001 tracking and delay information

New files:
- examples/src/collaborate/fan_in.rs — FanInHandler RequestHandler
  middleware that routes relay messages into the active executor's inbox
  channel instead of starting new executions
- examples/src/collaborate/agent.rs — CollabExecutor with both required
  extension URIs declared in AgentCard capabilities
- examples/src/collaborate/server.rs — shared server startup logic
- examples/src/collaborate/{orders,inventory,shipping}.rs — binary entry
  points (ports 9001, 9002, 9003)

Usage:
  # Terminal 1-3: start each agent
  cargo run --bin collaborate-orders    --package examples
  cargo run --bin collaborate-inventory --package examples
  cargo run --bin collaborate-shipping  --package examples

  # Terminal 4: query all three
  a2acli collaborate \
    --agent http://localhost:9001 \
    --agent http://localhost:9002 \
    --agent http://localhost:9003 \
    "Customer ORD-1001 has not received their order"

Closes #573. Part of #569.

Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
- Remove unused `a2a-collab` dependency from examples/Cargo.toml
  (the examples implement server-side FanIn; they do not use the
  relay helpers from a2a-collab)
- Fix clippy::while_let_loop in collaborate/agent.rs
- Fix clippy::collapsible_if in collaborate/agent.rs and fan_in.rs
- Fix rustfmt violations across examples, a2a-collab, a2a, a2acli
- Fix broken external link in a2acli/README.md
  (a2a-cli/specification/SPEC.md was removed; link to repo root)

Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
…b client API

Adds examples/src/collaborate/client.rs — a standalone binary that shows
programmatic use of the a2a-collab crate client-side:

- require_collaborative_extensions() pre-flight-checks each AgentCard
- Opens one streaming connection per agent
- Merges all streams with futures::stream::select_all
- Relays every StreamResponse to peer agents via translate_peer_response()
- Echo suppression: never routes an event back to its originator
- Sets return_immediately=true on all relay send_message calls

Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
…ssion

Replace the manual relay loop with CollaborativeSession::new(agents).start().
The example now only handles rendering — all relay orchestration lives in
a2a-collab as intended.

Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
Remove the SLIMRPC-specific collaborative channel extension that was
built on a separate SLIM service/channel. It's superseded by the new
relay-based collaborative task extension (a2a-collab crate + a2acli
collaborate subcommand).

Removed:
- A2A_COLLABORATIVE_CHANNEL_SERVICE and METHOD_COLLABORATE constants
- SlimRpcTransport::new_group(), new_group_with_connection(), collaborate()
- Server::register_collaborate() helper
- slimrpc_collaborate_broadcasts_to_every_other_member e2e test

The SLIMRPC native-mode server implementation (using SLIM shared-
responses) is deferred; see TODO(#569) in e2e.rs.

Closes #569

Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
@Tehsmash
Tehsmash force-pushed the chore/remove-slimrpc-collaborate branch from ae145ec to 0aa7e69 Compare November 20, 2026 16:21
@Tehsmash Tehsmash closed this Nov 20, 2026
@Tehsmash Tehsmash reopened this Nov 20, 2026
Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
@Tehsmash Tehsmash closed this Nov 20, 2026
@Tehsmash Tehsmash reopened this Nov 20, 2026
… removal

Signed-off-by: Sam Betts <1769706+Tehsmash@users.noreply.github.com>
@Tehsmash
Tehsmash marked this pull request as draft November 20, 2026 16:43
@Tehsmash
Tehsmash marked this pull request as ready for review November 20, 2026 16:43

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: implement A2A collaborative task extension (v1 spec)

1 participant