Repository navigation
feat(agent): modernize headless_agent_auth sample for a2a-sdk v0.3.x - #441
Conversation
Summary of ChangesHello @williamsmt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request does an excellent job of modernizing the headless_agent_auth sample to align with a2a-sdk v0.3.x. The transition from the deprecated authentication field to the new security and security_schemes in the AgentCard is well-executed. The updates to the streaming implementation in both agent.py and test_client.py are significant improvements, enhancing robustness and observability by leveraging the updates stream mode and properly handling intermediate steps. The dependency upgrades and middleware adjustments are also correctly implemented. I have a few minor suggestions to enhance code cleanliness and consistency, but overall, this is a high-quality and valuable update.
# Conflicts: # samples/python/agents/headless_agent_auth/uv.lock
- build the agent card with SDK types (SecurityScheme/OAuth2SecurityScheme/OAuthFlows/ClientCredentialsOAuthFlow) - drop leftover comments and unrelated ruff/docstring churn; restore api.py, agent_executor.py to main apart from the fix - fix duplicated imports in oauth2_middleware.py and duplicated __main__ block in test_client.py - test_client reads only the camelCase keys the SDK serializes - cap a2a-sdk below 1.0 (the sample uses the 0.3.x pydantic API) and relock
This PR updates the headless_agent_auth sample to align with the latest a2a-sdk (
v0.3.x) standards and improves agent observability.Key Changes:
security_schemesfields, replacing the deprecated authentication object.agent.pyto use updates stream mode, providing better visibility into intermediate tool steps and structured responses.test_client.pywith robust OAuth2 token resolution, improved timeout handling, and cleaner output for streaming events.v0.3.23with the[http-server]extra and updated middleware to support the newwell-known/agent-card.jsonendpoint.CONTRIBUTINGGuide.Fixes #409 🦕