Repository navigation
fix: deterministic AaveOracle and Spoke addresses (I-06) - #1370
Open
DhairyaSethi wants to merge 4 commits into
Open
DhairyaSethi wants to merge 4 commits into
DhairyaSethi wants to merge 4 commits into
Conversation
DhairyaSethi
added this pull request to stack #1371
October 7, 2026 19:17
…istic-spoke-oracle # Conflicts: # snapshots/TakerPositionManager.Operations.json
…istic-spoke-oracle
avniculae
added a commit
that referenced
this pull request
Oct 8, 2026
#1370 added a salt to _deployAaveOracle and a test helper that calls deployAaveV4 without the BabylonSpoke bytecode.
avniculae
added a commit
that referenced
this pull request
Oct 8, 2026
Mirrors #1370 for BabylonSpoke: the batch deploys its AaveOracle, so a CREATE-deployed batch left the oracle, implementation and proxy addresses dependent on the deployer's nonce.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes I-06 from the Certora config engine review. Spoke addresses no longer depend on the deployer's nonce.
AaveV4DeployBase.deploySpokeInstanceBatchdeploysAaveV4SpokeInstanceBatchthroughCreate2Utilsinstead ofnew.AaveOraclewithnew AaveOracle{salt: salt}. The batch stays the oracle'sDEPLOYER, sosetSpokestill runs in the batch constructor. A factory-deployed oracle would have the Safe Singleton Factory asDEPLOYERand could never be bound.deploySpokeInstanceBatchrepeats the batch's four input checks with the same messages.ContractAlreadyDeployed, like every other CREATE2 component.The gas snapshot deltas (±12–24) come from the new Spoke addresses in signature-based operations. Stacked on #1369.