Skip to content

TRANS-116 Bootstrap local environment - #71

Closed
Priyaj11 wants to merge 1 commit into
adyen-examples:mainfrom
Priyaj11:feature/TRANS-116-local-environment
Closed

Priyaj11 wants to merge 1 commit into
adyen-examples:mainfrom
Priyaj11:feature/TRANS-116-local-environment

Conversation

@Priyaj11

Copy link
Copy Markdown

Pins the runtime environment, documents the configuration surface, and
records the upstream boundary before any test code is written.

  • pyproject.toml pins Flask, the Adyen library, and python-dotenv, and
    requires Python 3.10 or newer. Upstream leaves Flask unpinned.

  • .env.example documents all five configuration variables with placeholders.

  • docs/UPSTREAM.md records what is Adyen's, what we changed, and why.

  • The inherited e2e workflow is disabled because it requires Adyen
    credentials as repository secrets and fails on every push without them.

    No upstream application code is modified.

Pin the runtime environment in pyproject.toml, document the configuration
surface in .env.example, and record the upstream boundary in docs/UPSTREAM.md.

Disable the inherited e2e workflow: it requires Adyen credentials as
repository secrets and fails on every push to a fork without them.

Upstream application code is unchanged.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request sets up the initial configuration, dependency management, and documentation for the Transact project, which is built on top of Adyen's Python online payments example. It adds a .env.example file for local environment configuration, a pyproject.toml file to pin runtime dependencies (Flask, Adyen, and python-dotenv), and a docs/UPSTREAM.md file to document the project's foundation and future roadmap. Additionally, the .gitignore file is updated to exclude virtual environments, caches, and test reports. Feedback on the changes suggests removing redundant entries from the .gitignore file, such as venv/, __pycache__/, and *.pyc, which are already defined earlier in the file.

Comment thread .gitignore
Comment on lines +18 to +24
.venv/
venv/
__pycache__/
*.pyc
.pytest_cache/
reports/
.coverage

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The entries venv/, __pycache__/, and *.pyc are already defined in the existing .gitignore file (lines 6, 10, and 9 respectively). Adding them again here introduces redundant duplicates. We should only add the new entries like .venv/, .pytest_cache/, reports/, and .coverage.

.venv/
.pytest_cache/
reports/
.coverage

@Priyaj11 Priyaj11 closed this Aug 28, 2026
@Priyaj11
Priyaj11 deleted the feature/TRANS-116-local-environment branch August 28, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants