Repository navigation
Conversation
Pin the runtime environment in pyproject.toml, document the configuration surface in .env.example, and record the upstream boundary in docs/UPSTREAM.md. Disable the inherited e2e workflow: it requires Adyen credentials as repository secrets and fails on every push to a fork without them. Upstream application code is unchanged.
There was a problem hiding this comment.
Code Review
This pull request sets up the initial configuration, dependency management, and documentation for the Transact project, which is built on top of Adyen's Python online payments example. It adds a .env.example file for local environment configuration, a pyproject.toml file to pin runtime dependencies (Flask, Adyen, and python-dotenv), and a docs/UPSTREAM.md file to document the project's foundation and future roadmap. Additionally, the .gitignore file is updated to exclude virtual environments, caches, and test reports. Feedback on the changes suggests removing redundant entries from the .gitignore file, such as venv/, __pycache__/, and *.pyc, which are already defined earlier in the file.
| .venv/ | ||
| venv/ | ||
| __pycache__/ | ||
| *.pyc | ||
| .pytest_cache/ | ||
| reports/ | ||
| .coverage |
There was a problem hiding this comment.
The entries venv/, __pycache__/, and *.pyc are already defined in the existing .gitignore file (lines 6, 10, and 9 respectively). Adding them again here introduces redundant duplicates. We should only add the new entries like .venv/, .pytest_cache/, reports/, and .coverage.
.venv/
.pytest_cache/
reports/
.coverage
Pins the runtime environment, documents the configuration surface, and
records the upstream boundary before any test code is written.
pyproject.toml pins Flask, the Adyen library, and python-dotenv, and
requires Python 3.10 or newer. Upstream leaves Flask unpinned.
.env.example documents all five configuration variables with placeholders.
docs/UPSTREAM.md records what is Adyen's, what we changed, and why.
The inherited e2e workflow is disabled because it requires Adyen
credentials as repository secrets and fails on every push without them.
No upstream application code is modified.