Repository navigation
Opt-in shared agent memory (#44) - #45
Merged
Merged
Conversation
… schema check and memory-sql command
…n near-duplicates
…nd dumps in memory writes
Resolve memory_vocabulary paths, log unknown stack tags once per process, and add end-to-end vocabulary tests including D6 recall tolerance.
… branches and paths pass
…lls; allow null and boolean values
…details, delete confirm and dark mode
PunchBui
requested changes
Oct 2, 2026
PunchBui
left a comment
PunchBui
left a comment
Collaborator
There was a problem hiding this comment.
Requesting changes for three issues. Each was reproduced by calling the tools over MCP on a6c7788. The files involved are unchanged in the commits since, so they still apply at the current head. Details and repros are in the inline comments.
supersedesis dropped when the corrected title differs only by a number, and the stale memory is confirmed instead.- The memory admin read routes have no identity check, so memories hidden by a
sensitivereport are readable. system,pathand other free-text context fields bypass the prompt-injection lint and are printed into other agents' recall results.
…ore the duplicate check
joeldickson
marked this pull request as ready for review
October 2, 2026 10:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #44: opt-in shared agent memory behind
memory_enabled(three MCP tools, SQLite and Postgres stores, keyword and hybrid recall, duplicate handling, reports, lint, vocabulary, admin view).Built slice by slice on this branch; squash-merged at the end. Draft until every slice lands and CI is green.
Memory page screenshots
These are the Playwright snapshot baselines in
client/tests/memory.spec.ts-snapshots/, rendered from mocked API data.List with recall stats and open reports
Details panel for a selected memory
Delete confirmation
Filtered to hidden memories
Empty state
Dark mode