Repository navigation
fix(guests)!: remove code from the guest create payloads (AIRLST-6003) - #147
Open
mish-ka-mishka wants to merge 1 commit into
Open
mish-ka-mishka wants to merge 1 commit into
mish-ka-mishka wants to merge 1 commit into
Conversation
The Suite always generates the guest code. Core PR airlst/core#6278 makes POST /events/{event}/guests and POST /guests/{code}/recommendations refuse a code in the body with 422. The companion endpoints ignore it. The SDK no longer declares code on CreateCompanionBodyInterface, so create(), createCompanion(), createRecommendation(), inline companions and GuestManager.create() do not accept it. The version is now 0.1.0. BREAKING CHANGE: a TypeScript caller that passes code to a create method gets a type error. Remove the field and read data.guest.code from the response. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Suite always generates the guest code (AIRLST-6003). Core PR https://github.com/airlst/core/pull/6278 is merged into master.
The SDK no longer declares
codeonCreateCompanionBodyInterface. All create bodies extend that interface, so no create method acceptscodenow.codein corecreate(),GuestManager.create()POST /events/{event}/guestscreateRecommendation()POST /events/{event}/guests/{code}/recommendationscreateCompanion()POST /events/{event}/guests/{code}/companionscompanions[]increate()create()The path parameter
code(for examplecreateCompanion('guest-code', …)) does not change.Version
0.0.24→0.1.0. The latest release is stable, so the skill rule increments the minor. The change breaks TypeScript callers that passcode. Confirm the version before the release.Verification
yarn run check,yarn run test --run(81 tests) andyarn run buildpass.tsc --strictfile with@ts-expect-erroroncodeincreate(),createRecommendation(),createCompanion(), inline companions andGuestManager.create()exited 0. The valid calls withoutcodecompile.Merge
Do not merge before core #6278 is on production. Do not release until then.
🤖 Generated with Claude Code