Repository navigation
fix(aws/autoscaling): converge ASG and capacity provider with ECS managed scaling - #2009
Merged
sam-goodwin merged 4 commits intoOct 6, 2026
Conversation
Contributor
|
Install the packages built from this commit: alchemypnpm install https://pkg.alchemy.run/alchemy/pr:2009:6756b37@alchemy.run (6)pnpm install https://pkg.alchemy.run/@alchemy.run/better-auth/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@alchemy.run/cloudflare-runtime/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@alchemy.run/frontend-frameworks/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@alchemy.run/node-utils/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@alchemy.run/floci/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@alchemy.run/pkg/pr:2009:6756b37@distilled.cloud (16)pnpm install https://pkg.alchemy.run/@distilled.cloud/core/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/acme/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/aws/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/axiom/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/cloudflare/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/doppler/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/fly-io/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/github/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/hetzner/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/infisical/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/neon/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/prisma/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/planetscale/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/railway/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/stripe/pr:2009:6756b37pnpm install https://pkg.alchemy.run/@distilled.cloud/zerossl/pr:2009:6756b37Published |
… tests Retry the distilled InvalidIamInstanceProfile tag (alchemy-run/distilled#764) on create and update instead of matching ValidationError messages, and catch AlreadyExistsFault by tag. Live tests in the existing suites: - AutoScalingGroup: a fresh instance profile + omitted desiredCapacity; an external scaler raises desired (Launch suspended) and a redeploy keeps it. On main the create fails with InvalidIamInstanceProfile and the redeploy resets desired to minSize. - CapacityProvider: remove and re-add a provider; on main the INACTIVE leftover is read as foreign and the deploy fails with OwnedBySomeoneElse. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
# Conflicts: # submodules/distilled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three convergence issues when an
AutoScalingGroupbacks an ECSCapacityProvider.updateAutoScalingGroupalways sentdesiredCapacity ?? minSize, undoing whatever ECS managed scaling had set. An omitteddesiredCapacitynow leaves the live value alone on update; create still defaults tominSize.Invalid IAM Instance Profileuntil the profile propagates.createAutoScalingGroupandupdateAutoScalingGroupnow retry it with backoff, typed in distilled asInvalidIamInstanceProfile(feat(aws/auto-scaling): type InvalidIamInstanceProfile on create/updateAutoScalingGroup distilled#764).INACTIVEfor a while, soread/reconciletried to update it instead of creating a new one.describenow skipsINACTIVEproviders, matching howServicealready filters them.Live tests in the existing suites:
AutoScalingGroup.test.tscreates a group whose launch template names a fresh instance profile, raises desired capacity externally (Launch suspended, no instance starts), and redeploys;CapacityProvider.test.tsremoves a provider and adds it back. Onmainthey fail withInvalidIamInstanceProfile, a desired capacity reset tominSize, andOwnedBySomeoneElsefor the INACTIVE leftover.