fix(core): ui connection test with null host and port - #72348
Open
Pedrinhonitz wants to merge 8 commits into
Open
fix(core): ui connection test with null host and port #72348Pedrinhonitz wants to merge 8 commits into
Pedrinhonitz wants to merge 8 commits into
Conversation
fix(core): test connection api ui solved apache#72318
Pedrinhonitz
requested review from
bugraoz93,
choo121600,
ephraimbuddy,
henry3260,
jason810496,
pierrejeambrun,
rawwar and
shubhamraj-git
as code owners
August 31, 2026 20:46
fix(ruff): format docstring
fix connection test with null host and port
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resume
Fixes #72318. In the UI's "Test Connection" feature, unused host/port fields were stored as NULL (None) in the database, while the UI sent an empty string (""). This discrepancy caused the system to treat it as a new destination, skip the password/extra merge, and pass
private_key_file="***"to the hook. Now, blank host/port fields are treated as the same destination, and***is not considered a new credential.Issues
Was generative AI tooling used to co-author this PR?
Generated-by: Cursor IA IDLE following the guidelines , to assist with understanding and documentation.