server: report distinct read/write volume throttle rates - #14048
Open
nagaboinaramgopal wants to merge 1 commit into
Open
server: report distinct read/write volume throttle rates#14048nagaboinaramgopal wants to merge 1 commit into
nagaboinaramgopal wants to merge 1 commit into
Conversation
VolumeJoinDaoImpl.newVolumeResponse fed the read getter to the write setter for the byte rate, and the write getter to the read setter for IOPS, so listVolumes returned the read byte-rate as the write byte-rate and the write IOPS as the read IOPS for any volume with asymmetric throttling. Map each rate to its own field. The assignments are extracted into setThrottleRates so the mapping is covered by a unit test.
DaanHoogland
approved these changes
Sep 4, 2026
DaanHoogland
left a comment
DaanHoogland
left a comment
Contributor
There was a problem hiding this comment.
clgtm, a true bug fixed
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #14048 +/- ##
============================================
- Coverage 16.34% 16.34% -0.01%
Complexity 13574 13574
============================================
Files 5669 5669
Lines 501368 501371 +3
Branches 60903 60903
============================================
- Hits 81964 81963 -1
- Misses 410219 410221 +2
- Partials 9185 9187 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VolumeJoinDaoImpl.newVolumeResponse fed the read getter to the write setter for the byte rate, and the write getter to the read setter for IOPS, so listVolumes returned the read byte-rate as the write byte-rate and the write IOPS as the read IOPS for any volume with asymmetric throttling. Map each rate to its own field.
Tested: new unit test on the extracted setThrottleRates helper; VolumeJoinDaoImplTest green