Repository navigation
Conversation
|
yangrui |
There was a problem hiding this comment.
Against #1547, this PR only covers the resource and YAML contract. Kinds, suffixes, affinityAware, v3.1, and the pre-write checks are in place. Config center, API, UI, and E2E belong in the follow-ups.
What blocks this is enabled / runtime. If those keys are missing, a read-back that gets published again writes them as false and turns off a rule that is currently active. Details on the lines below.
|
@AsperforMias need review |
|
|
LGTM for the resource/YAML-codec scope at Rechecked boolean field presence, non-empty rule validation, and the Affinity/Script nil-Spec guards. The package tests, race check, and my original nil-Spec reproducer all pass: The Script execution timeout remains tracked separately in apache/dubbo-go#3566 / apache/dubbo-go#3575. The configuration-center path-precedence and API/history findings remain with #1553 and #1554. This LGTM applies to #1552's resource/codec scope. |
|
@robocanic this seems enough LGTM for me, ask for check this guy's this pr |



Related issue
Related to #1547.
Summary
Testing
Notes
This is the first PR in a stacked series. Follow-up PRs add config-center propagation, Console APIs, the Vue UI, and E2E coverage.