Repository navigation
fix: complete Kubernetes provisioning for Dubbo observability dashboards - #1573
Merged
robocanic merged 1 commit intoSep 30, 2026
Merged
Conversation
|
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Complete the provisioning connections among the existing Kubernetes Observability resources: Grafana automatically discovers the six Dubbo dashboards, a Jaeger datasource is provisioned, and Kubernetes Admin is configured with the six corresponding dashboard URLs. This change depends on the Grafana Service DNS fix in D002 PR #1571. That PR has now been merged; D003 has been rebased onto its merged
developcommit, so this PR contains only the three D003 files below.Changes
release/kubernetes/monitoring/grafana-deployment.yaml: reuse the existing dashboard mount pattern, adding a volume and volume mount for each of the six Dubbo ConfigMaps under/grafana-dashboard-definitions/0/<dashboard name>. Dashboard JSON, UIDs, variables, and queries are unchanged.release/kubernetes/monitoring/grafana-dashboardDatasources.yaml: retain the existing Prometheus configuration and addname: jaeger,uid: fe670vj54q48wc,type: jaeger,access: proxy, andurl: http://jaeger.monitoring.svc:16686. The UID is the datasource value currently saved in the three trace dashboards. Reusing it is a compatibility choice, not restoration of a previously existing formal datasource configuration.release/kubernetes/dubbo-system/dubbo-admin.yaml: add the sixconsole.metricDashboards/console.traceDashboardsURLs usinghttp://grafana.monitoring.svc:3000/d/<corresponding dashboard UID>?kiosk=1&theme=light. Preserve the DNS corrected by D002 and the existing ConfigMap → volume → mount →-cloading path.Validation
The same external static Provisioning Oracle, with unchanged decision logic, reported:
YAML parsing of the three changed files,
kubectl create --dry-run=client --validate=false, andgit diff --checkpassed. A delegated Open Code Review of the three changed files found no clear blocking issue.Runtime provisioning has not been verified and is not claimed as PASS. No confirmed safe disposable Kubernetes environment was available for that validation. In such an environment, it remains necessary to verify that Grafana loads the six dashboards and the Jaeger datasource automatically, the trace dashboards resolve the datasource variable on first load, and the running Admin reads all six URLs. A static Oracle PASS does not replace these checks.
Dependency
D002 PR #1571 has been squash-merged into
apache/dubbo-admin:develop. D003 was rebased onto that merged commit. The PR diff contains only the three D003 files listed above and does not repeat the D002 changes.Related issue
Fixes #1572
Non-goals
This PR does not include the D002 baseline deployment fixes themselves, Service or Instance Trace query semantics, the OTel Collector,
k8sattributes, dashboard JSON rewrites, Log, Trace → Log / Log → Trace / Trace → Metric, or a claim that loading a dashboard proves business-level E2E queries pass.