Repository navigation
KNOX-3564: Increase DELEGATION_POLICY_USERS.username column size to 2048 to support SPIFFE IDs - #1505
Merged
Merged
Conversation
…048 to support SPIFFE IDs
Contributor
Author
|
Cc. @hsheinblatt |
Test Results 5 files 5 suites 1m 34s ⏱️ Results for commit e2bbeab. |
hanicz
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3564 - Increase DELEGATION_POLICY_USERS.username column size to 2048 to support SPIFFE IDs
What changes were proposed in this pull request?
The SPIFFE specification allows SPIFFE IDs of up to 2048 bytes (SPIFFE ID spec, section 2.3), but
DELEGATION_POLICY_USERS.usernamewasVARCHAR(1023), so longer SPIFFE IDs could not be stored as permitted users on a delegation policy.createKnoxIDFDelegationPolicyTables.sql:DELEGATION_POLICY_USERS.usernamechanged fromVARCHAR(1023)toVARCHAR(2048)createKnoxIDFDelegationPolicyTablesOracle.sql:DELEGATION_POLICY_USERS.usernamechanged fromVARCHAR2(1023)toVARCHAR2(2048)This also aligns the column with
DELEGATION_POLICIES.actor_id, which is already 2048.How was this patch tested?
DelegationPolicySchemaTest.testUsernameAcceptsMaxLengthSpiffeId, which stores and reads back a 2048-character SPIFFE ID inDELEGATION_POLICY_USERS(H2) and verifies that a 2049-character value is rejectedDelegationPolicySchemaTestandJdbcDelegationPolicyServiceTest: all tests passIntegration Tests
No integration test was added: this is a schema column size change, covered by the unit test above.