Repository navigation
KNOX-3565: Exclude snappy-java from hadoop-common - #1507
Merged
Merged
Conversation
pzampino
approved these changes
Nov 11, 2026
Test Results 5 files 5 suites 1m 37s ⏱️ Results for commit 13f0747. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3565 - Exclude snappy-java from hadoop-common
What changes were proposed in this pull request?
hadoop-common 3.4.1 transitively pulled
org.xerial.snappy:snappy-java:1.1.10.4into almost every module at compile scope, so the gateway shipped a version affected by CVE-2026-108106 (unbounded allocation on crafted compressed input, fixed in 1.1.10.9). Knox doesn't need snappy-java at runtime: only ZooKeeper's server-side snapshot code (SnapStream) and Hadoop'sSnappyCodecreference it, and Knox uses neither (Knox is a ZooKeeper client only, via Curator).hadoop-commondependency in the root pom, and from thehadoop-commontest-jar ingateway-test-release, which dependencyManagement doesn't cover.curator-test: embedded ZooKeeper servers started byTestingServerneed it, and hadoop-common had been supplying it silently. It's pinned to 1.1.10.12 at test scope (curator would otherwise bring 1.1.7).bannedDependenciesrule for snappy-java at compile/runtime scope, so it can't come back into the release through another dependency.How was this patch tested?
mvn dependency:tree -Dincludes=org.xerial.snappy:snappy-java: snappy-java 1.1.10.12 at test scope only, in the four modules with embedded ZooKeeper tests (gateway-server,gateway-service-remoteconfig,gateway-provider-ha,gateway-test).mvn validatepasses. Temporarily banning test scope too makes the build fail withFound Banned Dependency, which confirms the scoped ban pattern matches.gateway-server,gateway-service-remoteconfigandgateway-provider-hapass, as do the unit tests forgateway-spi,gateway-topology-hadoop-xml,gateway-provider-identity-assertion-hadoop-groupsandgateway-provider-security-hadoopauth.gateway-releaseruntime classpath: no Knox or Curator code reaches the classes that reference snappy-java.Integration Tests
No integration tests were added or changed; this is a dependency-only change. The existing CI suites cover the runtime behavior.