Repository navigation
Conversation
When pac4j clears a session value with set(key, null), KnoxSessionStore must emit an empty-value cookie. Since KNOX-3148 SetCookieHeader wrote the literal "null" instead. Write a null value as empty, as before.
Test Results 5 files 5 suites 1m 15s ⏱️ Results for commit eb07813. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KNOX-3599 - Write empty pac4j session cookie instead of "null"
What changes were proposed in this pull request?
When pac4j clears a session value with set(key, null), KnoxSessionStore must emit an empty-value cookie.
Since KNOX-3148 SetCookieHeader wrote the literal "null" instead. Write a null value as empty, as before.
How was this patch tested?
Unit test. An E2E with pac4j oidc or SAML client is still needed.