Skip to content

KNOX-3599: Write empty pac4j session cookie instead of "null" - #1530

Draft
bonampak wants to merge 1 commit into
apache:masterfrom
bonampak:KNOX-3599
Draft

bonampak wants to merge 1 commit into
apache:masterfrom
bonampak:KNOX-3599

Conversation

@bonampak

Copy link
Copy Markdown
Contributor

KNOX-3599 - Write empty pac4j session cookie instead of "null"

What changes were proposed in this pull request?

When pac4j clears a session value with set(key, null), KnoxSessionStore must emit an empty-value cookie.
Since KNOX-3148 SetCookieHeader wrote the literal "null" instead. Write a null value as empty, as before.

How was this patch tested?

Unit test. An E2E with pac4j oidc or SAML client is still needed.

When pac4j clears a session value with set(key, null), KnoxSessionStore must emit an empty-value cookie.
Since KNOX-3148 SetCookieHeader wrote
the literal "null" instead. Write a null value as empty, as before.
@github-actions

Copy link
Copy Markdown

Test Results

  5 files    5 suites   1m 15s ⏱️
227 tests 226 ✅ 1 💤 0 ❌
271 runs  270 ✅ 1 💤 0 ❌

Results for commit eb07813.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant