[cdc] Return an empty string for canal/aliyun enum index 0 - #10371
Open
jackylee-ch wants to merge 1 commit into
Open
jackylee-ch wants to merge 1 commit into
jackylee-ch wants to merge 1 commit into
Conversation
CanalFieldParser and AliyunFieldParser decode a MySQL enum by indexing options[elementIndex - 1]. MySQL stores index 0 for an empty or invalid enum value, so a row carrying it made the index -1 and threw ArrayIndexOutOfBoundsException, failing the sync job. Map a non-positive index to the empty string, which is MySQL's own representation of that value; valid 1-based indices are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
CanalFieldParserandAliyunFieldParserdecode a MySQLenumvalue by indexingoptions[elementIndex - 1]. MySQL stores index0for an empty or invalid enum value(e.g. a value inserted outside the declared members under a non-strict SQL mode), so a row
carrying it made the index
-1and threwArrayIndexOutOfBoundsException, failing thewhole canal / aliyun-DTS sync job.
This maps a non-positive index to the empty string — MySQL's own representation of that
value — before indexing. Valid 1-based indices are unchanged.
Tests
CanalFieldParserTest/AliyunFieldParserTestassert index0yields the empty stringand that valid indices still resolve to their members; both threw
ArrayIndexOutOfBoundsExceptionbefore the change.API and Format
No change.
Documentation
No change.