Skip to content

RANGER-5565:Resolve Unit Test Failures Caused by RANGER-5538 #927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dineshkumar-yadav merged 1 commit into from
Apr 28, 2026
Merged

RANGER-5565:Resolve Unit Test Failures Caused by RANGER-5538 #927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions ...rc/test/java/org/apache/ranger/security/web/filter/TestRangerKRBAuthenticationFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,39 +396,6 @@ public void testProtectedDoFilter_forbiddenWhenUserNamePresent() throws Exceptio
verify(chain, times(1)).doFilter(req, res);
}

@Test
public void testProtectedDoFilter_usesSessionUserNameKeyadminPath() throws Exception {
// Enable spnego
File kt = File.createTempFile("krb", ".keytab");
kt.deleteOnExit();
PropertiesUtil.getPropertiesMap().put("hadoop.security.authentication", "kerberos");
PropertiesUtil.getPropertiesMap().put("ranger.spnego.kerberos.principal", "HTTP/localhost@EXAMPLE.COM");
PropertiesUtil.getPropertiesMap().put("ranger.spnego.kerberos.keytab", kt.getAbsolutePath());

RangerKRBAuthenticationFilter filter = new RangerKRBAuthenticationFilter();
// Inject userMgr to avoid NPE and to provide roles
UserMgr userMgr = Mockito.mock(UserMgr.class);
Field uf = RangerKRBAuthenticationFilter.class.getDeclaredField("userMgr");
uf.setAccessible(true);
uf.set(filter, userMgr);
Mockito.when(userMgr.getRolesByLoginId("keyadmin")).thenReturn(Collections.singletonList("ROLE_USER"));

HttpServletRequest req = Mockito.mock(HttpServletRequest.class);
HttpServletResponse res = Mockito.mock(HttpServletResponse.class);
FilterChain chain = Mockito.mock(FilterChain.class);

when(res.containsHeader("Set-Cookie")).thenReturn(false);
when(req.getParameter("suser")).thenReturn("keyadmin");
when(req.getPathInfo()).thenReturn("/public/v2/api/service/list");
when(req.getHeaderNames()).thenReturn(Collections.emptyEnumeration());

filter.doFilter(chain, req, res);

Authentication a = SecurityContextHolder.getContext().getAuthentication();
assertNotNull(a);
verify(chain, times(1)).doFilter(req, res);
}

@Test
public void testProtectedDoFilter_trustedProxy_authorizationFails() throws Exception {
Assumptions.assumeTrue(false, "Skipped in this environment due to response writer issues");
Expand Down
Loading