Fix(eos_designs): Centralize injection of host-specific info for AristaAvdError and child classes by alexeygorbunov · Pull Request #6603 · aristanetworks/avd

alexeygorbunov · 2026-02-25T05:03:36Z

Change Summary

When host is specified in the inventory but it's group/host vars are missing type - AVD raises AristaAvdInvalidInputsError pointing to the host used by run_once task and not providing any info regarding the host that actually misses type definition: No device type found. Either set 'type' or 'default_node_types'.

In some other cases - impacted host is specified twice or incorrect host is specified instead of the one triggering the issue

Related Issue(s)

Fixes #

Component(s) name

arista.avd.avd_designs

Proposed changes

Add host_context_set: bool flag to AristaAvdError and use it as a trigger hor appending host-related suffix to the messages
Modify some message patterns

How to test

Pytest: eos_designs_negative_unit_tests

Checklist

User Checklist

N/A

Repository Checklist

My code has been rebased from devel before I start
I have read the CONTRIBUTING document.
My change requires a change to the documentation and documentation have been updated accordingly.
I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions · 2026-02-25T05:03:46Z

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-6603
# Activate the virtual environment
source test-avd-pr-6603/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/alexeygorbunov/avd.git@specify-host-when-node_type-not-found#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
python -m ansible.cli.galaxy collection install git+https://github.com/alexeygorbunov/avd.git#/ansible_collections/arista/avd/,specify-host-when-node_type-not-found --force
cd test-avd-pr-6603
# Run your playbook using `python -m ansible.cli.playbook path/to/playbook.yml ...`

gmuloc · 2026-02-25T08:20:40Z


-        msg = "No device type found. Either set 'type' or 'default_node_types'."
+        msg = f"No device type found for host '{self.hostname}'. Either set 'type' or 'default_node_types'."
        raise AristaAvdInvalidInputsError(msg, host=self.hostname)


this showing self.hostname should already have appended the hostname. I am not sure the current fix is the right one. Let me take a further look

We also seen such thing that when something failed on eos_designs_facts it do not show that which host throw that error. I am saying about eos designs molecule

we may have missed something in the error handling during the refactoring. ~~Although the expected error in the negative unit test suggests that this has been an issue for a while.~~

… classes

gmuloc · 2026-02-26T16:31:43Z

+            self.host_context_set = True
+        else:
+            self.host_context_set = host_context_set
+            self.message = message


Suggested change

self.message = message

class AristaAvdHostError(AristaAvdError):

host: str

def __init__(self, message: str, host: str ) -> None:

self.host = host ...

self.message = f"{message} for host {host}."

super().__init__(self.message, host = self.host)

- class AristaAvdInvalidInputsError(AristaAvdError): - ... + class AristaAvdInvalidInputsError(AristaAvdHostError): + pass

Implemented as suggested, except re-defining host for AristaAvdHostError as pyright doesn't like it

gmuloc · 2026-02-26T16:34:34Z

@@ -81,8 +81,7 @@ def get_facts(
            raise AristaAvdMissingVariableError(variable=e.variable, host=e.host or hostname) from e
        except AristaAvdError as e:


Suggested change

except AristaAvdError as e:

except AristaAvdHostError:

raise

except AristaAvdError as e:

# keep what's there

maybe you can remove all the try / except here and let's see the changes in the error messages

Removed try/except

for more information, see https://pre-commit.ci

gmuloc · 2026-02-27T14:47:04Z

+

-    def __init__(self, message: str, host: str | None = None) -> None:
+class AristaAvdInvalidInputsError(AristaAvdHostError):


I think the AristaAvdMissingVariableError should also inherit from the AristaAvdHostError

gmuloc · 2026-02-27T14:47:48Z

-class AristaAvdInvalidInputsError(AristaAvdError):
-    host: str | None
+class AristaAvdHostError(AristaAvdError):
+    def __init__(self, message: str, host: str = "") -> None:


why do you need a default here? (maybe thats required but just checking :) )

This is for the error message cases where "impacted" host is already mentioned in the body of the message and we don't want to prepend it again to the message. I could either pass host="" explicitly on the "calling" sides or just have host="" as a default in error class definition.
But another option is to review all places where we are raising those exceptions and to make sure they all use the same "pattern" (like they shouldn't be mentioning problematic host in the body of the message is we are supposed to prepand it later anyway)

yup makes sense so a possible way forward is that we do not update the message and in facts and wherever we need to add the hostname (bvecause we are running with run_once and we cannot know) we do it using the e.host to render the error message like we want.

Right now having it everywhere is actually (as we can see in the changes) going to render stuff like this:

fatal: [cv-pathfinder-edge1 -> localhost]: FAILED! => {"changed": false, "msg": "'ipv4_acl_in' must be set on WAN interfaces where 'wan_carrier' is set, unless the carrier is configured as 'trusted' under 'wan_carriers'. 'ipv4_acl_in' is missing on L3 interface 'Ethernet1/49.3' for host cv-pathfinder-edge1 ."}

for every failure in structured config which is a bit overkill today. What do you think? (I know this is going back and forth a bit :) )

github-actions · 2026-03-03T19:13:38Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2026-03-04T07:17:16Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

sonarqubecloud · 2026-03-16T19:30:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

github-actions · 2026-03-17T16:38:30Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

ClausHolbechArista · 2026-04-14T08:24:09Z

please address comments and resolve conflicts. Moving to draft for now, so please set it ready for review when done.

github-actions · 2026-05-07T15:27:52Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

sonarqubecloud · 2026-05-07T15:40:31Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov · 2026-05-07T15:48:22Z

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

github-actions · 2026-05-12T15:45:46Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Initial commit

c0cd348

github-actions Bot assigned alexeygorbunov Feb 25, 2026

github-actions Bot added the state: CI Updated CI scenario have been updated in the PR label Feb 25, 2026

alexeygorbunov marked this pull request as ready for review February 25, 2026 05:17

alexeygorbunov requested review from a team as code owners February 25, 2026 05:17

gmuloc reviewed Feb 25, 2026

View reviewed changes

Centralize injection of host-specic info for AristaAvdError and child…

c1ecf8f

… classes

alexeygorbunov changed the title ~~Fix(eos_designs): Expose hostnames for hosts with no found type~~ Fix(eos_designs): Centralize injection of host-specific info for AristaAvdError and child classes Feb 26, 2026

alexeygorbunov requested review from ClausHolbechArista, MaheshGSLAB and gmuloc February 26, 2026 04:52

ClausHolbechArista reviewed Feb 26, 2026

View reviewed changes

Comment thread ...xtensions/molecule/eos_designs_negative_unit_tests/inventory/host_vars/missing-mlag-peer.yml Resolved

gmuloc reviewed Feb 26, 2026

View reviewed changes

Comment thread python-avd/pyavd/_eos_designs/eos_designs_facts/utils.py Resolved

gmuloc reviewed Feb 26, 2026

View reviewed changes

alexeygorbunov and others added 6 commits February 26, 2026 11:06

Merge branch 'devel' into specify-host-when-node_type-not-found

840aa16

Commit to address part of the comments

d8d7bd9

[pre-commit.ci] auto fixes from pre-commit.com hooks

ac2a1fc

for more information, see https://pre-commit.ci

Extra molecule fixes

e6b964c

Merge branch 'devel' into specify-host-when-node_type-not-found

51307db

Linter fix

1c185b0

alexeygorbunov requested a review from gmuloc February 27, 2026 14:35

gmuloc reviewed Feb 27, 2026

View reviewed changes

alexeygorbunov and others added 2 commits February 27, 2026 09:23

Merge branch 'devel' into specify-host-when-node_type-not-found

47387d6

Make AristaAvdMissingVariableError child of AristaAvdHostError

87c4aef

github-actions Bot added the state: conflict PR with conflict label Mar 3, 2026

Merge branch 'devel' into specify-host-when-node_type-not-found

c5dd170

github-actions Bot removed the state: conflict PR with conflict label Mar 4, 2026

Make linter happy

4bf7cc6

carl-baillargeon requested a review from gmuloc March 5, 2026 18:37

MaheshGSLAB approved these changes Mar 6, 2026

View reviewed changes

alexeygorbunov and others added 3 commits March 13, 2026 12:43

Merge branch 'devel' into specify-host-when-node_type-not-found

571f14d

Merge branch 'devel' into specify-host-when-node_type-not-found

ca6d1a7

Merge branch 'devel' into specify-host-when-node_type-not-found

c2d4142

github-actions Bot added the state: conflict PR with conflict label Mar 17, 2026

gmuloc added this to the v6.2.0 milestone Mar 18, 2026

MaheshGSLAB mentioned this pull request Mar 23, 2026

Refactor(eos_designs): Inserting the dhcp accept default route when mgmt_ip is dhcp #6627

Merged

4 tasks done

ClausHolbechArista marked this pull request as draft April 14, 2026 08:24

gmuloc added 2 commits May 6, 2026 18:02

Merge branch 'devel' into specify-host-when-node_type-not-found

4eb58a3

Refactor: Additional things to covered following merge of devel

5c89865

github-actions Bot removed the state: conflict PR with conflict label May 7, 2026

github-actions Bot added the state: conflict PR with conflict label May 12, 2026

ClausHolbechArista removed this from the v6.2.0 milestone Jun 2, 2026

MaheshGSLAB mentioned this pull request Sep 22, 2026

Feat(eos_designs): Add support for recursive parent_profiles reference chain #7401

Merged

4 tasks done

alexeygorbunov closed this Oct 30, 2026

-            self.message = message
+class AristaAvdHostError(AristaAvdError):
+    host: str
+    def __init__(self, message: str, host: str ) -> None:
+      self.host = host ...
+      self.message = f"{message} for host {host}."
+      super().__init__(self.message, host = self.host)

		@@ -81,8 +81,7 @@ def get_facts(
		raise AristaAvdMissingVariableError(variable=e.variable, host=e.host or hostname) from e
		except AristaAvdError as e:



		def __init__(self, message: str, host: str \| None = None) -> None:
		class AristaAvdInvalidInputsError(AristaAvdHostError):

Conversation

alexeygorbunov commented Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Change Summary

Related Issue(s)

Component(s) name

Proposed changes

How to test

Checklist

User Checklist

Repository Checklist

Uh oh!

github-actions Bot commented Feb 25, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ClausHolbechArista Feb 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 3, 2026

Uh oh!

github-actions Bot commented Mar 4, 2026

Uh oh!

sonarqubecloud Bot commented Mar 16, 2026

Quality Gate passed

Uh oh!

github-actions Bot commented Mar 17, 2026

Uh oh!

ClausHolbechArista commented Apr 14, 2026

Uh oh!

github-actions Bot commented May 7, 2026

Uh oh!

sonarqubecloud Bot commented May 7, 2026

Quality Gate passed

Uh oh!

codecov Bot commented May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Welcome to Codecov 🎉

Uh oh!

github-actions Bot commented May 12, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

alexeygorbunov commented Feb 25, 2026 •

edited

Loading

ClausHolbechArista Feb 25, 2026 •

edited

Loading

codecov Bot commented May 7, 2026 •

edited

Loading