Skip to content

ci(strix): post scan report as PR comment and fail on findings - #25

Merged
arumes31 merged 5 commits into
mainfrom
chore/strix-pr-comment
Oct 27, 2026
Merged

arumes31 merged 5 commits into
mainfrom
chore/strix-pr-comment

Conversation

@arumes31

Copy link
Copy Markdown
Owner

Updates the Strix workflow (same change as arumes31/rauth#768):

  • The scan report is captured, redacted (model name, key, endpoint) and uploaded as an artifact.
  • A separate Strix PR comment job posts/updates one PR comment with the report. Only that job gets pull-requests: write; the job that runs PR code and the LLM keeps a read-only token.
  • The check now fails when Strix reports vulnerabilities (it was always green before); scanner errors and timeouts remain warnings.

The repository's existing actions/checkout pin is kept.

🤖 Generated with Claude Code

- Capture and redact the Strix report and upload it as an artifact.
- Post/update a single PR comment from a separate job that holds the only
  write-capable token (the job running PR code and the LLM never does).
- Fail the check when Strix reports vulnerabilities; scanner errors and
  timeouts stay warnings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: adcd1d2b-2d44-4065-bf82-3957c2625f5c
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T22:26:16.960758Z 9ed98a0 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ed98a0428

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +157 to +160
if [[ "$FINDINGS" == "true" ]]; then
status="vulnerabilities reported"
else
status="no vulnerabilities reported"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Distinguish incomplete scans from clean scans

When Strix times out or exits with any scanner error, FINDINGS remains unset, so this branch labels the PR comment “no vulnerabilities reported” even though the scan did not complete; the preceding workflow section explicitly classifies exit codes 124/137 as timeouts and other nonzero codes as failures. Because these outcomes intentionally leave the check green, the success-like comment can conceal that no reliable security result exists; use a separate incomplete/error status for nonzero, non-findings exit codes.

Useful? React with 👍 / 👎.

arumes31 and others added 3 commits October 27, 2026 23:32
The full report can contain secrets or exploit details the scanner finds and
comments/artifacts are public on public repositories (flagged by Strix on
arumes31/hackwerk#29). Comment titles + severities only; pass the summary as a
job output instead of an artifact.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The full report can contain secrets or exploit details the scanner finds and
comments/artifacts are public on public repositories (flagged by Strix on
arumes31/hackwerk#29). Comment titles + severities only; pass the summary as a
job output instead of an artifact.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Strix security scan: no vulnerabilities reported

Commit ea709d3 · exit code 0 · workflow run

Details are in the workflow run log.

actionlint/shellcheck flagged individual redirects to GITHUB_OUTPUT.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@arumes31
arumes31 merged commit b9876b3 into main Oct 27, 2026
37 checks passed
@arumes31
arumes31 deleted the chore/strix-pr-comment branch October 27, 2026 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant