Skip to content

bridge: RQ-PLUG-TELEMETRY-OFF - #246

Merged
masonwyatt23 merged 12 commits into
ashlrai:mainfrom
masonwyatt23:codex-bridge/RQ-PLUG-TELEMETRY-OFF
Oct 27, 2026
Merged

masonwyatt23 merged 12 commits into
ashlrai:mainfrom
masonwyatt23:codex-bridge/RQ-PLUG-TELEMETRY-OFF

Conversation

@masonwyatt23

@masonwyatt23 masonwyatt23 commented Oct 26, 2026 •

Copy link
Copy Markdown
Member

Automated bridge job RQ-PLUG-TELEMETRY-OFF (pool: codex-personal), single commit on base e17e8f291.

Tests: no test command

Agent notes

RQ-PLUG-TELEMETRY-OFF

Summary:

  • Added nine offline telemetry regression tests in __tests__/telemetry-offline.test.ts.
  • Seven disabled-consent modes assert zero fetch attempts even with previously queued events and repeated flushes; recording helpers remain inert, backlog stays unchanged, and no session/consent stamp is created.
  • Added same-process consent revocation coverage and CLI subprocess coverage against a loopback collector, with an enabled positive control proving the collector receives requests.
  • Current telemetry code lives in servers/_telemetry.ts and scripts/telemetry-flush.ts; the requested src/telemetry/ directory does not exist. Existing production guards already satisfy these tests, so no production changes were needed.

Commands and results:

  • bun install --frozen-lockfile: passed; installed missing dependencies without changing the lockfile.
  • HOME=$(mktemp -d) bun run typecheck: final run passed (exit 0). Earlier runs exposed missing dependencies and then a Bun fetch mock typing issue; both resolved.
  • HOME=$(mktemp -d) bun run mdx-lint: passed, 84 files scanned (repository lint command).
  • HOME=$(mktemp -d) bun test __tests__/telemetry-offline.test.ts __tests__/telemetry.test.ts __tests__/telemetry-track1.test.ts __tests__/telemetry-events.test.ts __tests__/orchestrate-emit-telemetry.test.ts: final run 77 passed, 0 failed, 340 assertions across 5 files; new tests 9 passed, 0 failed.
  • git diff --check: passed.

Scope: disabled telemetry only; this does not assert that unrelated plugin features avoid networking. CLI network checks use only a local collector. All test runs used temporary HOME directories. No commits, pushes, or protected configuration changes.

Net LOC: +148 lines across two new files (tests +130, bridge notes +18); 0 removed.

Summary by CodeRabbit

  • Tests
    • Added coverage confirming telemetry remains inactive when consent is disabled or revoked, and that opted-in CLI telemetry can reach a local collector. No user-facing behavior changes are included in this update.

@masonwyatt23
masonwyatt23 enabled auto-merge (squash) October 26, 2026 18:24
@vercel

vercel Bot commented Oct 26, 2026

Copy link
Copy Markdown

@masonwyatt23 is attempting to deploy a commit to the Evero Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration
Commits

Reviewing files that changed from the base of the PR and between eaea49b and 718da9b.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between e17e8f2 and eb22d3c.

Files selected for processing: 1
  • __tests__/telemetry-offline.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 2 remain after this review.

Walkthrough

This change adds offline telemetry tests for disabled consent modes, consent revocation before a later flush, and CLI behavior with disabled or enabled telemetry.

Changes: Offline telemetry test coverage

Layer / File(s) Summary
Consent and flush behavior
__tests__/telemetry-offline.test.ts
Tests verify that disabled telemetry skips flushing without calling fetch or changing backlog and telemetry files. A revocation test checks that a later flush skips after consent changes to off. CLI tests check disabled-mode behavior and an opted-in run against a local collector.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: Minimal · previous review eb22d

The new telemetry tests cover disabled consent, revocation, and an opted-in CLI send. No issue identified here needs resolution before merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "bridge: RQ-PLUG-TELEMETRY-OFF" names the telemetry-off scope, which matches the changeset: offline telemetry regression tests for disabled consent, consent revocation, and CLI behavior. It …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "bridge: RQ-PLUG-TELEMETRY-OFF" names the telemetry-off scope, which matches the changeset: offline telemetry regression tests for disabled consent, consent revocation, and CLI behavior. It does not state the main change in plain words. It also uses an internal ticket-style token (RQ-PLUG-TELEMETRY-OFF) and a 'bridge:' prefix without context. The changeset adds tests only, with no production changes, and the title does not say so. The title is related to the changeset but is not fully descriptive, so it passes as partially related.

Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@masonwyatt23
masonwyatt23 marked this pull request as draft October 26, 2026 21:09
auto-merge was automatically disabled October 26, 2026 21:09

Pull request was converted to draft

@masonwyatt23
masonwyatt23 marked this pull request as ready for review October 26, 2026 23:28
@masonwyatt23
masonwyatt23 enabled auto-merge (squash) October 26, 2026 23:28
@sonarqubecloud

Copy link
Copy Markdown

@masonwyatt23
masonwyatt23 merged commit 057104e into ashlrai:main Oct 27, 2026
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant