Skip to content

bridge: RQ-STACK12A103010Q8 - #278

Merged
masonwyatt23 merged 1 commit into
ashlrai:mainfrom
masonwyatt23:codex-bridge/RQ-STACK12A103010Q8
Oct 30, 2026
Merged

masonwyatt23 merged 1 commit into
ashlrai:mainfrom
masonwyatt23:codex-bridge/RQ-STACK12A103010Q8

Conversation

@masonwyatt23

@masonwyatt23 masonwyatt23 commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Automated bridge job RQ-STACK12A103010Q8 (pool: codex-cmp), single commit on base 641832260.

Tests: no test command

Tier-1 (CODEOWNERS) paths, async post-merge review: packages/mcp/tests/list-json.test.ts

Agent notes

Bridge notes

  • Added an MCP end-to-end test for an empty stack, checking valid compact JSON, the complete empty-services contract, and parity with the CLI.
  • No existing tests were skipped or deleted; no dead code was identified in the touched area.
  • bun install --frozen-lockfile: passed.
  • HOME=$(mktemp -d) bun test packages/mcp/__tests__/list-json.test.ts: passed, 5 tests, 0 failures, 3 snapshots, 28 assertions.
  • Initial concurrent test run: 1 passed, 4 failed and 1 unhandled error after the new test timed out and the shared server was terminated; the revised fixture passed on rerun.
  • HOME=$(mktemp -d) bun run lint: passed, 293 files checked.
  • HOME=$(mktemp -d) bun run typecheck: passed.
  • git diff --check: passed.
  • Net LOC: 18 in the test file; 11 in this file; 29 total.

Summary by CodeRabbit

  • Tests
    • Added coverage confirming that listing a stack with no services in JSON format matches the CLI’s JSON output.

@vercel

vercel Bot commented Oct 30, 2026

Copy link
Copy Markdown

@masonwyatt23 is attempting to deploy a commit to the Evero Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Walkthrough

The test helper now accepts a project directory. A new test checks that stack_list returns the expected JSON for an empty stack and matches the CLI’s list --json output.

Changes: Empty-stack JSON contract

Layer / File(s) Summary
Project-scoped CLI contract test
packages/mcp/__tests__/list-json.test.ts
The CLI contract helper accepts an optional project directory. A new test compares stack_list JSON output for an empty stack with the CLI’s list --json output.

Priority: Not assessed

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Possibly related PRs

Merge Risk: Minimal · up to b14ba

This change adds focused empty-stack contract coverage and is ready to merge.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@masonwyatt23
masonwyatt23 added this pull request to the merge queue Oct 30, 2026
Merged via the queue into ashlrai:main with commit cac377b Oct 30, 2026
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant