Repository navigation
Conversation
It was possible to corrupt data when reading a very large scan (> 2^32 points) because of a type mismatch between some capacities and indices (size_t vs. unsigned int). Fixes #357
Owner
Author
|
@MeshMatze I can't say I understand all the stuff going on in that example, but running it produced expected results before and after the fix (see above). I can only test this on macOS. Can you check it on Windows and/or Linux by any chance? Because it changes the public API, I'm going to hold off merging this until version 4.0. I'm not sure too many people are using single scans with more than 4.3 billion points, so it's not too pressing… Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
NOTE: This changes the
CompressedVectorReaderAPI, so it will have to wait for 4.0 to be merged.Summary
It was possible to corrupt data when reading a very large scan (> 2^32 points) because of a type mismatch between some capacities and indices (size_t vs. unsigned int).
Fixed by changing
unsigned inttosize_tthroughout.Additional Notes
I generated the test file based on the example in #357. It resulted in a ~26GB file with the following structure:
Before the fix:
After the fix:
Note that I could only test this on macOS.
Fixes #357
Checklist