Repository navigation
fix(rust): cap aws-smithy-types below 1.7 (aws-smithy-json 0.63 compat) - #2375
hanabanaka wants to merge 1 commit into
Conversation
aws-smithy-types 1.7.0 changed Document::Object to carry a new DocumentObject struct instead of HashMap<String, Document>. The aws-smithy-json 0.63.0 that the pinned aws-sdk-* / aws-config versions resolve is written against the old shape and fails to compile against 1.7.0 (E0308 mismatched types + E0004 non-exhaustive match), breaking test_rust for both DynamoDbEncryption and TestVectors. The direct pin was aws-smithy-types = "1.3.6" -- a floor that Cargo floats up to the newest 1.x, so publishing 1.7.0 silently pulled it in. Cap it to ">=1.3.6, <1.7" so the runtime stays on the 1.6.x line (the resolution that built cleanly before 1.7.0 shipped), until the aws-sdk-* deps advance to an aws-smithy-json that supports 1.7.
|
Closing — no longer needed. The breakage was a transient window while Evidence: #2374, whose library runtime is byte-identical to This cap also pins |
Cap
aws-smithy-typesbelow1.7in the Rust runtimes sotest_rustkeeps compiling.aws-smithy-types 1.7.0changedDocument::Objectto carry a newDocumentObjectstruct instead ofHashMap<String, Document>. Theaws-smithy-json 0.63.0pulled in by the pinnedaws-sdk-*/aws-configversions is written against the old shape and fails to compile against1.7.0(E0308 + E0004), which is currently red onmainand every PR.The direct pin was
aws-smithy-types = "1.3.6"— a floor Cargo floats up to the newest1.x, so1.7.0silently got pulled in. Capping to>=1.3.6, <1.7keeps the runtimes on the1.6.xline (the resolution that built cleanly before1.7.0shipped). Applies to bothDynamoDbEncryption/runtimes/rustandTestVectors/runtimes/rust.