Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeleteItemRequest.expectedwhen the mapper has no version assertion or user-provided expected conditions.Expectedinstead of serializing"Expected": {}.This removes construction and defensive copying of an empty map from the common delete path.
Compatibility
DynamoDB service behavior is unchanged. Code that inspects the low-level request through an interceptor or mock can observe
expected() == nullinstead of an empty map for an unconditional delete.Testing
Performance
The baseline and candidate ran on separate, equivalently configured
c6g.metalhosts using JMH3-3-2,-prof gc, deterministic stub clients, and the complete 24-case Mapper v2 matrix.The full matrix initially showed GET/HUGE_FLAT at -3.08%. A focused
5-5-2rerun measured 174,830 ops/s for the baseline and 176,162 ops/s for the candidate, a statistically insignificant +0.76%, confirming it was unrelated benchmark noise.Complete throughput matrix