Repository navigation
Stream dists to reduce max memory - #81
Merged
Merged
Conversation
bbits from 14 -> 16 prevents backwards compatibility
Closes #18 Uses formatted strings in a buffer to send to a writer thread Keeps old functions which don't steam for e.g. PopPUNK, but CLI will use these by default
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
==========================================
+ Coverage 90.65% 91.44% +0.78%
==========================================
Files 17 17
Lines 3232 3623 +391
==========================================
+ Hits 2930 3313 +383
- Misses 302 310 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
Author
|
On 10k samples, ~21Mb sketches (~18Mb in v0.3.0), 1.4Gb output file Seems to work nicely, and also a bit of a performance boost as the writing out is done a lot more quickly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #80
Closes #18
Uses formatted strings in a buffer to send to a writer thread
Keeps old functions which don't steam for e.g. PopPUNK, but CLI will use these by default