Repository navigation
Fix pin-staleness job: stop update_toolchains.py crashing, bump stale pypa pins - #43
Merged
Merged
Conversation
… pypa pins update_toolchains.py's arm-none-eabi/riscv-none-elf entries still grepped an ARG TOOLCHAIN_URL= line that [0087]/[0089] deleted from embedded_base.Dockerfile, so _pinned() raised SystemExit on the very first pin and crashed the whole checker -- every scheduled pin-staleness.yml run since has been reporting a hard failure, not real drift, with the other five pins never actually checked. Both crosses now read every verified version pinned for them out of resources/pinned_toolchains.toml and report whether the newest has fallen behind upstream, since that table (unlike the old Dockerfile ARG) genuinely holds more than one version at once. Also ran bin/update_docker.py to move the 34 pypa base image pins that had drifted to quay.io's 2026.09.05-1 build (record 0046: this reports, a human decides -- moving the pin in this reviewed diff is that decision), plus the 14 GHCR-mirrored unix cells in pinned_docker_images.toml that track them. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013RZbGBbjecbLb7ywKhuUoW
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_toolchains.py's arm-none-eabi/riscv-none-elf entries still grepped an
ARG TOOLCHAIN_URL= line that [0087]/[0089] deleted from embedded_base.Dockerfile,
so _pinned() raised SystemExit on the very first pin and crashed the whole
checker -- every scheduled pin-staleness.yml run since has been reporting a
hard failure, not real drift, with the other five pins never actually checked.
Both crosses now read every verified version pinned for them out of
resources/pinned_toolchains.toml and report whether the newest has fallen
behind upstream, since that table (unlike the old Dockerfile ARG) genuinely
holds more than one version at once.
Also ran bin/update_docker.py to move the 34 pypa base image pins that had
drifted to quay.io's 2026.09.05-1 build (record 0046: this reports, a human
decides -- moving the pin in this reviewed diff is that decision), plus the
14 GHCR-mirrored unix cells in pinned_docker_images.toml that track them.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_013RZbGBbjecbLb7ywKhuUoW