Repository navigation
docs: use a synthetic token in the writes example, drop a version pin - #255
Merged
Merged
Conversation
The example in docs/writes.md carried a token captured from a live run. Harmless, since the signing key is per process and it expired five minutes later, but a made-up one reads the same and is not an artefact of somebody's instance. The replacement keeps the real shape, v1.<base36 ms>.<43-char base64url>, and its timestamp is a round 2026-01-01 so it is plainly an example. The comment in write.ts pinned "Hermes since 2026.9.7", which dates quietly and duplicates what docs/writes.md already says in prose. The issue reference (#234) stays, being stable and useful. No behaviour change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
bardesss
added a commit
that referenced
this pull request
Nov 6, 2026
…#255) The example in docs/writes.md carried a token captured from a live run. Harmless, since the signing key is per process and it expired five minutes later, but a made-up one reads the same and is not an artefact of somebody's instance. The replacement keeps the real shape, v1.<base36 ms>.<43-char base64url>, and its timestamp is a round 2026-01-01 so it is plainly an example. The comment in write.ts pinned "Hermes since 2026.9.7", which dates quietly and duplicates what docs/writes.md already says in prose. The issue reference (#234) stays, being stable and useful. No behaviour change. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The two nits from the #249 review, now that the code they sit in has merged. No behaviour change, no test change.
docs/writes.md— the preview example carried a token captured from a live run (mu13yno6decodes to 2026-09-14T10:36:42Z). Harmless, since the signing key is per process and it died five minutes later, but it was an artefact of a real instance sitting in the docs for no reason. The replacement keeps the real shape,v1.<base36 ms>.<43-char base64url>, and its timestamp is a round2026-01-01T00:00:00Zso it reads as an example rather than a capture.src/tools/write.ts— the comment pinned "Hermes since 2026.9.7", which dates quietly and duplicates whatdocs/writes.mdalready says in prose two files over. The#234reference stays, being stable and worth having. Five lines to four.The three gates
Same 2683 as before, since nothing here is executable.
🤖 Generated with Claude Code