Part 6: Revamped AES Lightengine CFB mode from core API tweaks - #111
Open
officialfrancismendoza wants to merge 4 commits into
Conversation
officialfrancismendoza
marked this pull request as draft
September 2, 2026 12:27
officialfrancismendoza
requested review from
dghgit
and removed request for
dghgit
September 2, 2026 12:27
dghgit
changed the base branch from
release/0.1.3alpha
to
feature/aes-tweaks
September 2, 2026 14:17
dghgit
changed the title
dghgit
approved these changes
Sep 2, 2026
dghgit
left a comment
dghgit
left a comment
Contributor
There was a problem hiding this comment.
Sanity check passed, ACVP passed.
Fabel 5.1 audit, passed.
Squash of the original two commits (7f96e1b "Initial add of revamped CFB mode based off of aes-tweaks" and 2a5d834 "Restored file changes on 3 files to resolve failing checks issues"), whose net effect is this change; the first had reverted three files the second restored. Rebased onto feature/aes-tweaks at 0d06cf9; the port to the in-place block cipher API follows in a separate commit.
… API Follows ede3b9e (core: block cipher data methods work in place) and 60e0cc0 (core: fold BlockCipher into Algorithm) on feature/aes-tweaks: * Cfb implements Algorithm (its permutation's name and strength) and the in-place hooks do_encrypt_blocks / do_decrypt_blocks. decrypt_pair builds the two cipher inputs in its keystream buffer, so the only extra copy is C_{j+1} for the chaining value. * block_mode_cmd streams through a mutable buffer and writes it back out after transforming it, with no separate output buffer. * The CFB tests and benches use the same by-value helpers and iter_batched setup as the CBC ones; the AES_CFB_* doctests and crate docs show the in-place calls. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dghgit
force-pushed
the
feature/officialfrancismendoza/103-from-aes-tweaks-CFB-mode
branch
from
September 3, 2026 07:34
2cf944a to
f07e73e
Compare
Contributor
Author
|
@dghgit checked post force-push, seems fine. |
officialfrancismendoza
marked this pull request as ready for review
September 3, 2026 09:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building upon previous work on aes-lowmemory derivative crate (#98, #99) and CBC mode compatible with the aes-lowmemory derivative (#100, #101); specifically to implement AES CFB mode for the new aes-lowmemory crate and factoring in the new changes to the core API design.
This feature branch implements the lowmemory derivative of AES, with its corresponding CFB mode (#103), to be compatible with the new BlockCipherEncryptor / BlockCipherDecryptor split and BlockPermutation.