Repository navigation
fix(ci): pin Trivy SARIF upload to PR head ref - #2891
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the pull request Trivy SARIF upload to the PR head ref and commit SHA to prevent code scanning ruleset stalls on job retries and branch updates.
Under
on: pull_requesttriggers,upload-sarif@v4defaults to uploading against the temporary test-merge ref (refs/pull/<pr>/merge) and ephemeral merge commit. If downstream repositories require Trivy in their branch protection rulesets (Require code scanning results), any retry, rerun, or merge ref recalculation shifts the merge commit SHA and leaves the PR stuck waiting for Trivy.This separates the upload step by event type:
ref: refs/pull/<pr>/headandsha: github.event.pull_request.head.sha, binding the scan to the immutable PR head commit.mainretain the default ambient ref and SHA.Closes #2890