make pull packets include the cover - #287
Merged
Merged
Conversation
nahiyankhan
force-pushed
the
redesign/cover-on-pull
branch
from
September 6, 2026 21:00
b7f52e4 to
2149ba9
Compare
nahiyankhan
marked this pull request as ready for review
September 6, 2026 21:03
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: improvement
User Impact: Every pulled guidance packet now carries the package's unconditional brand context without requiring an agent to remember a special flag.
Problem:
gatherpreviously mixed unconditional cover guidance into the selection menu context, whilepullreturned only selected nodes. A fresh agent receiving a pull could therefore lose the package stance, and selection was influenced by prose that was not itself selectable.Solution: Make
gathera menu-only selection surface and make every successfulpullassemble a self-contained packet: resolved cover, clearly sourced fallback when needed, selected nodes, then starting structures. Selection IDs and automatic cover inclusion remain separate in the embed API and local event tape.Validation:
pnpm run quality:all: passedpnpm check:terminology: passedChangeset: added as a minor release because gather and pull public contracts change.
ghost Review:
File changes
.changeset/cover-on-pull.mdRecords the public gather and pull contract change.
packages/ghost/src/embed/*Separates cover and fallback from selected nodes, automatically transports the cover on pull, keeps gather menu-only, and exports the new result types.
packages/ghost/src/commands/*Supports bare pulls, formats self-contained Markdown and JSON packets, preserves selected-ID telemetry, and updates CLI discovery.
packages/ghost/src/observability-events.tsRecords the automatically included cover separately from selected IDs.
packages/ghost/test/*Covers menu-only gather, cover-first and bare pulls, absent and dangling covers, explicit cover aliases, unknown IDs, ordering, materials, skeletons, telemetry, and public output alignment.
packages/context-control/*Removes cover prose from selection-model input and updates the benchmark contract and presentation.
packages/steering-control/README.mdDocuments that selected pulls now include the cover.
README.md,packages/ghost/README.md,docs/purposes.md,packages/ghost/src/skill-bundle/*Updates the package model, command workflow, handoff guidance, and host-facing documentation.
Screenshots/Demos: N/A; no visual product surface changed.